Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: recipe_modules/rietveld/api.py

Issue 1917433002: Generalize patch_project to patch root conversion. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: -line long Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « recipe_modules/gclient/config.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_modules/rietveld/api.py
diff --git a/recipe_modules/rietveld/api.py b/recipe_modules/rietveld/api.py
index aa7374fc3f7735ac410bcd1b42f0c794b05091a2..b52ec0bc96632180d4857ef3f796d0b70f3cc048 100644
--- a/recipe_modules/rietveld/api.py
+++ b/recipe_modules/rietveld/api.py
@@ -11,6 +11,11 @@ class RietveldApi(recipe_api.RecipeApi):
def calculate_issue_root(self, extra_patch_project_roots=None):
"""Returns path where a patch should be applied to based on "patch_project".
+ YOU SHOULD NOT USE THIS METHOD. Put this into gclient's config as
+ patch_projects instead, and with luck you won't need to use
+ calculate_patch_root from gclient api.
+ TODO(tandrii): remove this method completely. See http://crbug.com/605563.
+
Maps Rietveld's "patch_project" to a path of directories relative to
api.gclient.c.solutions[0].name which describe where to place the patch.
« no previous file with comments | « recipe_modules/gclient/config.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698