Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: recipe_modules/bot_update/api.py

Issue 1917433002: Generalize patch_project to patch root conversion. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: recipe_modules/bot_update/api.py
diff --git a/recipe_modules/bot_update/api.py b/recipe_modules/bot_update/api.py
index 31a27335c82c2d67528b6906cce51b748dfd6c98..a8d7a7b43b52e6b6744d022d7ce4fc7b55aba293 100644
--- a/recipe_modules/bot_update/api.py
+++ b/recipe_modules/bot_update/api.py
@@ -85,6 +85,12 @@ class BotUpdateApi(recipe_api.RecipeApi):
# Construct our bot_update command. This basically be inclusive of
# everything required for bot_update to know:
root = patch_root
+ if root == 'TODO(TANDRII): REMOVE THIS TRANSITION TO patch_projects':
+ assert patch_project_roots is None
+ root = self.m.gclient.calculate_patch_root(
+ self.m.properties.get('patch_project'), cfg)
+ # TODO(tandrii): get rid the condition below after transition.
+
if root is None:
root = cfg.solutions[0].name
additional = self.m.rietveld.calculate_issue_root(patch_project_roots)

Powered by Google App Engine
This is Rietveld 408576698