Add Hyphenation class

Add Hyphenation class

This patch adds the Hyphenation class that abstracts hyphenation
dictionaries.

Actual implementation for each platform will be in following patches.

BUG=605840
Committed: https://crrev.com/fb48debb85ab0c12492cf63d780602e15f284222
Cr-Commit-Position: refs/heads/master@{#390307}

[kojii, 2016-04-27 07:17:35]

Description was changed from

==========
hyphenation

BUG=
==========

to

==========
Add Hyphenation class

This patch adds the Hyphenation class that abstracts hyphenation
dictionaries.

Actual implementation for each platform will be in following patches.

BUG=605840
==========

[kojii, 2016-04-27 07:18:44]

kojii@chromium.org changed reviewers:
+ drott@chromium.org, eae@chromium.org

[kojii, 2016-04-27 07:18:44]

PTAL.

[eae, 2016-04-27 07:25:21]

LGTM

[drott, 2016-04-27 10:10:26]

Can I find something like a larger architectural outline of your implementation
plan somewhere, or for example a WiP CL with the next steps? Something like that
might make it easier to follow along and review this and subsequent CLs.

[kojii, 2016-04-27 10:20:52]

On 2016/04/27 at 10:10:26, drott wrote:
> Can I find something like a larger architectural outline of your
implementation plan somewhere, or for example a WiP CL with the next steps?
Something like that might make it easier to follow along and review this and
subsequent CLs.

This is all the API surface in my current plan.

I think we discussed that we need 2 APIs; one to get the existence of
dictionaries for a locale, and the other to get hyphenation index in a string.
Mac OS X has exactly the 2 APIs, and I think that fits well for Android too.
https://developer.apple.com/library/ios/documentation/CoreFoundation/Referenc...

Next step is to implement Mac/Android implementation, and line breaker/preferred
width etc.

[drott, 2016-04-27 12:21:39]

Thanks for the details, Koji.

On 2016/04/27 at 10:20:52, kojii wrote:
> On 2016/04/27 at 10:10:26, drott wrote:
> > Can I find something like a larger architectural outline of your
implementation plan somewhere, or for example a WiP CL with the next steps?
Something like that might make it easier to follow along and review this and
subsequent CLs.
> 
> This is all the API surface in my current plan.
> 
> I think we discussed that we need 2 APIs; one to get the existence of
dictionaries for a locale, and the other to get hyphenation index in a string.
Mac OS X has exactly the 2 APIs, and I think that fits well for Android too.
>
https://developer.apple.com/library/ios/documentation/CoreFoundation/Referenc...

Yes we discussed this on a high level and it might be a good start. I'd just
like to suggest as an additional consideration: If I understood Raph correctly,
the dictionaries that are available on Android will have something like an array
of weighted hyphenation options. For compound words for example "Hauseingang"
(house entrance) => "Haus1ein2gang", where breaking after full words in a
compound might be preferred over breaking the words themselves, so as a return
value representation this might be { [ 3, weight1 ], [ 5, weight2 ] } or some
other associative representation. I am not sure about whether we need weighted
hyphenation indices at this point, but they probably come in handy when
considering optimized flow.

> Next step is to implement Mac/Android implementation, and line
breaker/preferred width etc.

Alright.

[kojii, 2016-04-27 12:56:00]

On 2016/04/27 at 12:21:39, drott wrote:
> Thanks for the details, Koji.
> 
> On 2016/04/27 at 10:20:52, kojii wrote:
> > On 2016/04/27 at 10:10:26, drott wrote:
> > > Can I find something like a larger architectural outline of your
implementation plan somewhere, or for example a WiP CL with the next steps?
Something like that might make it easier to follow along and review this and
subsequent CLs.
> > 
> > This is all the API surface in my current plan.
> > 
> > I think we discussed that we need 2 APIs; one to get the existence of
dictionaries for a locale, and the other to get hyphenation index in a string.
Mac OS X has exactly the 2 APIs, and I think that fits well for Android too.
> >
https://developer.apple.com/library/ios/documentation/CoreFoundation/Referenc...
> 
> Yes we discussed this on a high level and it might be a good start. I'd just
like to suggest as an additional consideration: If I understood Raph correctly,
the dictionaries that are available on Android will have something like an array
of weighted hyphenation options. For compound words for example "Hauseingang"
(house entrance) => "Haus1ein2gang", where breaking after full words in a
compound might be preferred over breaking the words themselves, so as a return
value representation this might be { [ 3, weight1 ], [ 5, weight2 ] } or some
other associative representation. I am not sure about whether we need weighted
hyphenation indices at this point, but they probably come in handy when
considering optimized flow.

Thank you, that explains some code in Minikin I haven't understood yet. I'm
hoping to go through the code in the debugger with data files, but your words
helps a lot.

I can see that it helps when we do optimized flow, I prefer to add that when we
have better idea on how it works. Until then, we'll need to pick one anyway. I
don't have good idea how to pick from the weight atm, I will talk to you/Raph
and read some code to understand that better.


> > Next step is to implement Mac/Android implementation, and line
breaker/preferred width etc.
> 
> Alright.

Great. Oh, forgot the mock, I think that should come first.

[kojii, 2016-04-28 05:22:17]

The CQ bit was checked by kojii@chromium.org

[kojii, 2016-04-28 05:22:18]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1917423002/#ps40001
(title: "Build fix")

[commit-bot: I haz the power, 2016-04-28 05:22:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1917423002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1917423002/40001

[commit-bot: I haz the power, 2016-04-28 05:27:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:16:23]

Patchset 3 (id:??) landed as
https://crrev.com/fb48debb85ab0c12492cf63d780602e15f284222
Cr-Commit-Position: refs/heads/master@{#390307}

[commit-bot: I haz the power, 2016-04-30 17:54:18]

Description was changed from

==========
Add Hyphenation class

This patch adds the Hyphenation class that abstracts hyphenation
dictionaries.

Actual implementation for each platform will be in following patches.

BUG=605840
==========

to

==========
Add Hyphenation class

This patch adds the Hyphenation class that abstracts hyphenation
dictionaries.

Actual implementation for each platform will be in following patches.

BUG=605840

Committed: https://crrev.com/fb48debb85ab0c12492cf63d780602e15f284222
Cr-Commit-Position: refs/heads/master@{#390307}
==========