Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: tools/perf/benchmarks/oortonline.py

Issue 1917393002: [tools/perf] Reference legacy_page_test module instead of page_test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/benchmarks/octane.py ('k') | tools/perf/benchmarks/robohornet_pro.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import page_sets 5 import page_sets
6 6
7 from core import perf_benchmark 7 from core import perf_benchmark
8 from telemetry import benchmark 8 from telemetry import benchmark
9 from telemetry.page import page_test 9 from telemetry.page import legacy_page_test
10 from telemetry.value import scalar 10 from telemetry.value import scalar
11 from telemetry.value import improvement_direction 11 from telemetry.value import improvement_direction
12 from telemetry.timeline import tracing_category_filter 12 from telemetry.timeline import tracing_category_filter
13 from telemetry.web_perf import timeline_based_measurement 13 from telemetry.web_perf import timeline_based_measurement
14 from telemetry.web_perf.metrics import v8_gc_latency 14 from telemetry.web_perf.metrics import v8_gc_latency
15 from telemetry.web_perf.metrics import smoothness 15 from telemetry.web_perf.metrics import smoothness
16 from telemetry.web_perf.metrics import memory_timeline 16 from telemetry.web_perf.metrics import memory_timeline
17 17
18 18
19 class _OortOnlineMeasurement(page_test.PageTest): 19 class _OortOnlineMeasurement(legacy_page_test.LegacyPageTest):
20 20
21 def __init__(self): 21 def __init__(self):
22 super(_OortOnlineMeasurement, self).__init__() 22 super(_OortOnlineMeasurement, self).__init__()
23 23
24 def ValidateAndMeasurePage(self, page, tab, results): 24 def ValidateAndMeasurePage(self, page, tab, results):
25 tab.WaitForJavaScriptExpression('window.benchmarkFinished', 1000) 25 tab.WaitForJavaScriptExpression('window.benchmarkFinished', 1000)
26 scores = tab.EvaluateJavaScript('window.benchmarkScore') 26 scores = tab.EvaluateJavaScript('window.benchmarkScore')
27 for score in scores: 27 for score in scores:
28 valid = score['valid'] 28 valid = score['valid']
29 if valid: 29 if valid:
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 @classmethod 88 @classmethod
89 def Name(cls): 89 def Name(cls):
90 return 'oortonline_tbm' 90 return 'oortonline_tbm'
91 91
92 @classmethod 92 @classmethod
93 def ValueCanBeAddedPredicate(cls, value, is_first_result): 93 def ValueCanBeAddedPredicate(cls, value, is_first_result):
94 if value.tir_label in ['Begin', 'End']: 94 if value.tir_label in ['Begin', 'End']:
95 return value.name.startswith('memory_') and 'v8_renderer' in value.name 95 return value.name.startswith('memory_') and 'v8_renderer' in value.name
96 else: 96 else:
97 return value.tir_label == 'Running' 97 return value.tir_label == 'Running'
OLDNEW
« no previous file with comments | « tools/perf/benchmarks/octane.py ('k') | tools/perf/benchmarks/robohornet_pro.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698