Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1917303002: Remove unmatched restore call in gamma GM (Closed)

Created:
4 years, 8 months ago by Brian Osman
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M gm/gamma.cpp View 1 chunk +0 lines, -2 lines 2 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917303002/1
4 years, 8 months ago (2016-04-26 21:25:37 UTC) #3
Brian Osman
4 years, 8 months ago (2016-04-26 21:25:50 UTC) #5
robertphillips
https://codereview.chromium.org/1917303002/diff/1/gm/gamma.cpp File gm/gamma.cpp (right): https://codereview.chromium.org/1917303002/diff/1/gm/gamma.cpp#newcode87 gm/gamma.cpp:87: // is guaranteed to draw that way, though. Doesn't ...
4 years, 8 months ago (2016-04-26 21:27:53 UTC) #7
Brian Osman
https://codereview.chromium.org/1917303002/diff/1/gm/gamma.cpp File gm/gamma.cpp (right): https://codereview.chromium.org/1917303002/diff/1/gm/gamma.cpp#newcode142 gm/gamma.cpp:142: canvas->restore(); Nope, this one does.
4 years, 8 months ago (2016-04-26 21:31:20 UTC) #8
robertphillips
lgtm
4 years, 8 months ago (2016-04-26 21:33:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917303002/1
4 years, 8 months ago (2016-04-26 21:36:32 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 21:37:31 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5529b7dccc13af9021a7e8e99a683ee3048c3ef3

Powered by Google App Engine
This is Rietveld 408576698