Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1917283003:
Add a test for not signaling sync points after context loss (Closed)
|
Created:
4 years, 8 months ago by danakj Modified:
4 years, 7 months ago CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, dcheng, Ken Russell (switch to Gerrit), piman Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a test for not signaling sync points after context loss
If the lost context callback has been run on a context, then
sync point callbacks should not happen.
R=piman@chromium.org, sievers@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/7ea3524b20690f356975a5287f8c7b3524b9b444
Cr-Commit-Position: refs/heads/master@{#389958}
Patch Set 1 #Patch Set 2 : signal-and-lost: comment #Patch Set 3 : signal-and-lost: . #Patch Set 4 : signal-and-lost: . #Messages
Total messages: 25 (12 generated)
Description was changed from ========== Add a sync point test for not signaling sync points after context loss R=piman@chromium.org, sievers@chromium.org BUG=584497 ========== to ========== Add a sync point test for not signaling sync points after context loss If the lost context callback has been run on a context, then sync point callbacks should not happen. R=piman@chromium.org, sievers@chromium.org BUG=584497 ==========
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917283003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== Add a sync point test for not signaling sync points after context loss If the lost context callback has been run on a context, then sync point callbacks should not happen. R=piman@chromium.org, sievers@chromium.org BUG=584497 ========== to ========== Add a sync point test for not signaling sync points after context loss If the lost context callback has been run on a context, then sync point callbacks should not happen. R=piman@chromium.org, sievers@chromium.org BUG=584497 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917283003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917283003/40001
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Updated the CL to be two GLES2Impl tests.
Description was changed from ========== Add a sync point test for not signaling sync points after context loss If the lost context callback has been run on a context, then sync point callbacks should not happen. R=piman@chromium.org, sievers@chromium.org BUG=584497 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add a test for not signaling sync points after context loss If the lost context callback has been run on a context, then sync point callbacks should not happen. R=piman@chromium.org, sievers@chromium.org BUG=584497 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917283003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917283003/60001
The CQ bit was unchecked by danakj@chromium.org
lgtm
The CQ bit was checked by danakj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917283003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917283003/60001
Message was sent while issue was closed.
Description was changed from ========== Add a test for not signaling sync points after context loss If the lost context callback has been run on a context, then sync point callbacks should not happen. R=piman@chromium.org, sievers@chromium.org BUG=584497 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add a test for not signaling sync points after context loss If the lost context callback has been run on a context, then sync point callbacks should not happen. R=piman@chromium.org, sievers@chromium.org BUG=584497 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Add a test for not signaling sync points after context loss If the lost context callback has been run on a context, then sync point callbacks should not happen. R=piman@chromium.org, sievers@chromium.org BUG=584497 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add a test for not signaling sync points after context loss If the lost context callback has been run on a context, then sync point callbacks should not happen. R=piman@chromium.org, sievers@chromium.org BUG=584497 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/7ea3524b20690f356975a5287f8c7b3524b9b444 Cr-Commit-Position: refs/heads/master@{#389958} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/7ea3524b20690f356975a5287f8c7b3524b9b444 Cr-Commit-Position: refs/heads/master@{#389958}
Message was sent while issue was closed.
On 2016/04/27 00:50:03, commit-bot: I haz the power wrote: > Patchset 4 (id:??) landed as > https://crrev.com/7ea3524b20690f356975a5287f8c7b3524b9b444 > Cr-Commit-Position: refs/heads/master@{#389958} I am disabling GLES2ImplementationTest.SignalSyncTokenAfterContextLoss, because it depends on r389947, which I reverted because it broke other tests. See https://codereview.chromium.org/1923733003. |
