Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1917253002: [chrome.displaySource] Fix buffer overflow in elementary stream packetizer. (Closed)

Created:
4 years, 8 months ago by e_hakkinen
Modified:
4 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chrome.displaySource] Fix buffer overflow in elementary stream packetizer. PES packet header buffer in Wi-Fi Display elementary stream packetizer did not contain space for stuffing bytes used for unit data alignment. That resulted in stack-buffer-overflow. BUG=242107 Committed: https://crrev.com/f130da124e3d4272f181bfdd30152c56da121702 Cr-Commit-Position: refs/heads/master@{#390026}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M extensions/renderer/api/display_source/wifi_display/wifi_display_elementary_stream_packetizer.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/api/display_source/wifi_display/wifi_display_elementary_stream_packetizer.cc View 4 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
e_hakkinen
PTAL.
4 years, 8 months ago (2016-04-26 18:31:48 UTC) #2
Mikhail
lgtm
4 years, 8 months ago (2016-04-26 18:34:02 UTC) #3
asargent_no_longer_on_chrome
Doesn't look like there's anything specific I need to look at, and Mikhail is in ...
4 years, 8 months ago (2016-04-26 19:09:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917253002/1
4 years, 7 months ago (2016-04-27 08:10:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 08:52:10 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 08:53:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f130da124e3d4272f181bfdd30152c56da121702
Cr-Commit-Position: refs/heads/master@{#390026}

Powered by Google App Engine
This is Rietveld 408576698