GN: Move boringssl_tests into build_with_chromium condition

third_party/boringssl/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build_overrides/build.gni")
 import("//testing/libfuzzer/fuzzer_test.gni")
 import("BUILD.generated.gni")
 import("BUILD.generated_tests.gni")
@@ skipping 107 matching lines @@
   configs += [ ":internal_config" ]
 
   configs -= [ "//build/config/compiler:chromium_code" ]
   configs += [ "//build/config/compiler:no_chromium_code" ]
 
   if (is_nacl) {
     deps += [ "//native_client_sdk/src/libraries/nacl_io" ]
   }
 }
 
-create_tests("boringssl_tests") {
-  configs = [ ":internal_config" ]
-  deps = [
-    ":boringssl",
-  ]
-}
+if (build_with_chromium) {
+  create_tests("boringssl_tests") {

[davidben, 2016/04/27 17:16:16]

I think the root problem here is I forget the annoying configs -= chromium_code
/ configs += no_chromium_code lines here. Do you mind putting that in? That will
suppress the warning which matches how Chromium builds the rest of BoringSSL and
how BoringSSL builds itself. Though I should maybe see about making us
chromium_code-clean if it's considered kosher for //third_party bits to use it.

I'll defer to you whether you want to continue suppressing the tests. There's no
reason they shouldn't be able to build, but it's also true they're not being
used.

[kjellander_chromium, 2016/04/27 20:07:21]

I prefer you do that in a separate CL. My main objective here is to not compile
the tests at all when we build the default (all) target for GN in WebRTC. In
order to do so, this is the only way AFAIK.

[davidben, 2016/04/27 22:52:31]

Sounds good. I'll deal with that separately then. lgtm.

+    configs = [ ":internal_config" ]
+    deps = [
+      ":boringssl",
+    ]
+  }
 
-if (build_with_chromium) {
   test("boringssl_unittests") {
     deps = [
       ":boringssl_tests",
       "//base",
       "//base/test:run_all_unittests",
       "//base/test:test_support",
       "//testing/gtest",
     ]
     sources = [
       "boringssl_unittest.cc",
@@ skipping 28 matching lines @@
       sources = [
         "src/fuzz/${fuzzer}.cc",
       ]
       deps = [
         ":boringssl_fuzzer",
       ]
       seed_corpus = "src/fuzz/${fuzzer}_corpus"
     }
   }
 }