Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 1917223002: Add an extra check in NavigateRemoteFrameToBlankAndDataURLs. (Closed)

Created:
4 years, 7 months ago by nasko
Modified:
4 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an extra check in NavigateRemoteFrameToBlankAndDataURLs. This CL adds an explicit navigation from within an iframe to about:blank. It verifies that the iframe stays in the same process after navigation has completed as the initiator of the navigation is the iframe itself. BUG=591509 Committed: https://crrev.com/d948aa86b4ab06738c7d8c67fb13bf42d95a1ff3 Cr-Commit-Position: refs/heads/master@{#389862}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M content/browser/site_per_process_browsertest.cc View 3 chunks +37 lines, -2 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
nasko
Hey Nick, Can you review this CL for me? It adds an explicit test for ...
4 years, 7 months ago (2016-04-26 16:23:15 UTC) #2
ncarter (slow)
lgtm https://codereview.chromium.org/1917223002/diff/1/content/browser/site_per_process_browsertest.cc File content/browser/site_per_process_browsertest.cc (right): https://codereview.chromium.org/1917223002/diff/1/content/browser/site_per_process_browsertest.cc#newcode1385 content/browser/site_per_process_browsertest.cc:1385: DepictFrameTree(root)); lgtm If you are working on improving ...
4 years, 7 months ago (2016-04-26 18:40:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917223002/1
4 years, 7 months ago (2016-04-26 19:53:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-26 19:59:01 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 20:00:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d948aa86b4ab06738c7d8c67fb13bf42d95a1ff3
Cr-Commit-Position: refs/heads/master@{#389862}

Powered by Google App Engine
This is Rietveld 408576698