WTF: Make PassOwnPtr<T> move-only.

WTF: Make PassOwnPtr<T> move-only.

This patch locks down copying of PassOwnPtr<T> to facilitate migration
of OwnPtr to std::unique_ptr. This is the first step of filling the
functionality gap between OwnPtr and std::unique_ptr.

After this change, copying of PassOwnPtrs won't be possible; to express
ownership transfer, you need to explicitly use std::move() if the
PassOwnPtr is an lvalue. Also, you may need to use passed() wrapper
function if you want to bind a PassOwnPtr to a function and want the
pointer auto-passed to the function on the functor's first invocation.

This patch also includes fixes for the code landed after my earlier mass
fixes of compile errors.

BUG=582349
Committed: https://crrev.com/70be800ca4cef83ffda469480e437fea66851c70
Cr-Commit-Position: refs/heads/master@{#390336}

[Yuta Kitamura, 2016-04-27 08:32:32]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 08:32:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1917193006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1917193006/1

[Yuta Kitamura, 2016-04-27 08:33:44]

Description was changed from

==========
WTF: Make PassOwnPtr<T> move-only.

This patch locks down copying of PassOwnPtr<T> to facilitate migration
of OwnPtr to std::unique_ptr. This is the first step of filling the
functionality gap between OwnPtr and std::unique_ptr.

After this change, copying of PassOwnPtrs won't be possible; to express
ownership transfer, you need to explicitly use std::move() if the
PassOwnPtr is an lvalue. Also, you may need to use passed() wrapper
function if you want to bind a PassOwnPtr to a function and want the
pointer auto-passed to the function on the functor's first invocation.

This patch also includes fixes for the code landed after my earlier mass
fixes of compile errors.

BUG=582349
==========

to

==========
WTF: Make PassOwnPtr<T> move-only.

This patch locks down copying of PassOwnPtr<T> to facilitate migration
of OwnPtr to std::unique_ptr. This is the first step of filling the
functionality gap between OwnPtr and std::unique_ptr.

After this change, copying of PassOwnPtrs won't be possible; to express
ownership transfer, you need to explicitly use std::move() if the
PassOwnPtr is an lvalue. Also, you may need to use passed() wrapper
function if you want to bind a PassOwnPtr to a function and want the
pointer auto-passed to the function on the functor's first invocation.

This patch also includes fixes for the code landed after my earlier mass
fixes of compile errors.

BUG=582349
==========

[Yuta Kitamura, 2016-04-27 08:33:45]

yutak@chromium.org changed reviewers:
+ haraken@chromium.org, tzik@chromium.org

[Yuta Kitamura, 2016-04-27 08:33:45]

yutak@chromium.org changed required reviewers:
+ haraken@chromium.org, tzik@chromium.org

[Yuta Kitamura, 2016-04-27 08:41:46]

PTAL!

I will send a PSA to blink-dev regarding this change shortly.
I won't land this change until tomorrow, so we can gather
enough feedback to the PSA.

+tzik for general review,
+haraken for approval.

Thanks!

[tzik, 2016-04-27 09:40:14]

lg

https://codereview.chromium.org/1917193006/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/PassOwnPtr.h (right):

https://codereview.chromium.org/1917193006/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/PassOwnPtr.h:87: mutable PtrType m_ptr;
Can we remove this "mutable" now?

[georgekidd13, 2016-04-27 09:52:36]

georgekidd13@gmail.com changed reviewers:
+ georgekidd13@gmail.com

[georgekidd13, 2016-04-27 09:52:38]

lgtm

[georgekidd13, 2016-04-27 09:52:40]

lgtm

lgtm

[georgekidd13, 2016-04-27 09:52:42]

lgtm

lgtm

lgtm

[commit-bot: I haz the power, 2016-04-27 09:55:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 09:55:04]

Dry run: This issue passed the CQ dry run.

[Mikhail, 2016-04-27 09:57:09]

mikhail.pozdnyakov@intel.com changed reviewers:
+ mikhail.pozdnyakov@intel.com

[Mikhail, 2016-04-27 09:57:10]

https://codereview.chromium.org/1917193006/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/PassOwnPtr.h (right):

https://codereview.chromium.org/1917193006/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/PassOwnPtr.h:50: // It somewhat breaks the type
system to allow transfer of ownership out of
Now this comment looks outdated.

[Yuta Kitamura, 2016-04-27 10:09:20]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 10:09:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1917193006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1917193006/20001

[Yuta Kitamura, 2016-04-27 10:10:34]

yutak@chromium.org changed reviewers:
+ tkent@chromium.org

[Yuta Kitamura, 2016-04-27 10:10:34]

yutak@chromium.org changed required reviewers:
+ tkent@chromium.org

[Yuta Kitamura, 2016-04-27 10:10:35]

PTAL again?

+tkent for approval for changes in public/.

https://codereview.chromium.org/1917193006/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/PassOwnPtr.h (right):

https://codereview.chromium.org/1917193006/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/PassOwnPtr.h:50: // It somewhat breaks the type
system to allow transfer of ownership out of
On 2016/04/27 09:57:10, Mikhail wrote:
> Now this comment looks outdated.

You are right; removed.

https://codereview.chromium.org/1917193006/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/PassOwnPtr.h:87: mutable PtrType m_ptr;
On 2016/04/27 09:40:14, tzik wrote:
> Can we remove this "mutable" now?

Yep, but removing this "mutable" has caused an error in
leakPtr() being const, which caused several errors in
public/platform etc. Fixed anyway.

[tzik, 2016-04-27 10:12:03]

lgtm

[tkent, 2016-04-27 10:43:34]

lgtm

[Mikhail, 2016-04-27 10:45:34]

lgtm

[haraken, 2016-04-27 11:00:05]

LGTM

[commit-bot: I haz the power, 2016-04-27 11:46:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 11:46:48]

Dry run: This issue passed the CQ dry run.

[Yuta Kitamura, 2016-04-28 06:49:43]

The CQ bit was checked by yutak@chromium.org

[Yuta Kitamura, 2016-04-28 06:49:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
georgekidd13@gmail.com, tkent@chromium.org, haraken@chromium.org,
mikhail.pozdnyakov@intel.com, tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/1917193006/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-04-28 06:49:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1917193006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1917193006/40001

[commit-bot: I haz the power, 2016-04-28 09:22:35]

Description was changed from

==========
WTF: Make PassOwnPtr<T> move-only.

This patch locks down copying of PassOwnPtr<T> to facilitate migration
of OwnPtr to std::unique_ptr. This is the first step of filling the
functionality gap between OwnPtr and std::unique_ptr.

After this change, copying of PassOwnPtrs won't be possible; to express
ownership transfer, you need to explicitly use std::move() if the
PassOwnPtr is an lvalue. Also, you may need to use passed() wrapper
function if you want to bind a PassOwnPtr to a function and want the
pointer auto-passed to the function on the functor's first invocation.

This patch also includes fixes for the code landed after my earlier mass
fixes of compile errors.

BUG=582349
==========

to

==========
WTF: Make PassOwnPtr<T> move-only.

This patch locks down copying of PassOwnPtr<T> to facilitate migration
of OwnPtr to std::unique_ptr. This is the first step of filling the
functionality gap between OwnPtr and std::unique_ptr.

After this change, copying of PassOwnPtrs won't be possible; to express
ownership transfer, you need to explicitly use std::move() if the
PassOwnPtr is an lvalue. Also, you may need to use passed() wrapper
function if you want to bind a PassOwnPtr to a function and want the
pointer auto-passed to the function on the functor's first invocation.

This patch also includes fixes for the code landed after my earlier mass
fixes of compile errors.

BUG=582349
==========

[commit-bot: I haz the power, 2016-04-28 09:22:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:17:14]

Patchset 3 (id:??) landed as
https://crrev.com/70be800ca4cef83ffda469480e437fea66851c70
Cr-Commit-Position: refs/heads/master@{#390336}

[commit-bot: I haz the power, 2016-04-30 17:54:58]

Description was changed from

==========
WTF: Make PassOwnPtr<T> move-only.

This patch locks down copying of PassOwnPtr<T> to facilitate migration
of OwnPtr to std::unique_ptr. This is the first step of filling the
functionality gap between OwnPtr and std::unique_ptr.

After this change, copying of PassOwnPtrs won't be possible; to express
ownership transfer, you need to explicitly use std::move() if the
PassOwnPtr is an lvalue. Also, you may need to use passed() wrapper
function if you want to bind a PassOwnPtr to a function and want the
pointer auto-passed to the function on the functor's first invocation.

This patch also includes fixes for the code landed after my earlier mass
fixes of compile errors.

BUG=582349
==========

to

==========
WTF: Make PassOwnPtr<T> move-only.

This patch locks down copying of PassOwnPtr<T> to facilitate migration
of OwnPtr to std::unique_ptr. This is the first step of filling the
functionality gap between OwnPtr and std::unique_ptr.

After this change, copying of PassOwnPtrs won't be possible; to express
ownership transfer, you need to explicitly use std::move() if the
PassOwnPtr is an lvalue. Also, you may need to use passed() wrapper
function if you want to bind a PassOwnPtr to a function and want the
pointer auto-passed to the function on the functor's first invocation.

This patch also includes fixes for the code landed after my earlier mass
fixes of compile errors.

BUG=582349

Committed: https://crrev.com/70be800ca4cef83ffda469480e437fea66851c70
Cr-Commit-Position: refs/heads/master@{#390336}
==========