Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1917183002: Remove redundant test (Closed)

Created:
4 years, 8 months ago by msarett
Modified:
4 years, 8 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove redundant test FlattenDrawable test now exercises the use of custom unflatten procs. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1917183002 Committed: https://skia.googlesource.com/skia/+/c5db972fce6eb3da2362c1e4e502f9fef01968f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M tests/FlattenDrawableTest.cpp View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917183002/1
4 years, 8 months ago (2016-04-26 15:24:24 UTC) #3
msarett
4 years, 8 months ago (2016-04-26 15:24:33 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/6397) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on ...
4 years, 8 months ago (2016-04-26 15:26:17 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917183002/1
4 years, 8 months ago (2016-04-26 15:27:47 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot/builds/3163) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on ...
4 years, 8 months ago (2016-04-26 15:28:35 UTC) #11
mtklein
lgtm
4 years, 8 months ago (2016-04-26 16:01:14 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917183002/1
4 years, 8 months ago (2016-04-26 19:46:22 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 19:56:14 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917183002/1
4 years, 8 months ago (2016-04-26 19:58:53 UTC) #18
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 19:59:50 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c5db972fce6eb3da2362c1e4e502f9fef01968f1

Powered by Google App Engine
This is Rietveld 408576698