Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5454)

Unified Diff: chrome/browser/media/webrtc_browsertest_base.h

Issue 1917133002: WebRtcBrowserTest tests with RSA and ECDSA certificates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc_browsertest_base.h
diff --git a/chrome/browser/media/webrtc_browsertest_base.h b/chrome/browser/media/webrtc_browsertest_base.h
index 1bb5d10f2180087b0af9aec59b9b40015464f1ba..b8a868a70973a27e7f91ebcaeaa62ace85842f13 100644
--- a/chrome/browser/media/webrtc_browsertest_base.h
+++ b/chrome/browser/media/webrtc_browsertest_base.h
@@ -95,10 +95,18 @@ class WebRtcTestBase : public InProcessBrowserTest {
// Sets up a peer connection in the tab and adds the current local stream
// (which you can prepare by calling one of the GetUserMedia* methods above).
- void SetupPeerconnectionWithLocalStream(content::WebContents* tab) const;
+ // Optionally, |certificate_keygen_algorithm| is JavaScript for an
+ // |AlgorithmIdentifier| to be used as parameter to
+ // |RTCPeerConnection.generateCertificate|. The resulting certificate will be
+ // used by the peer connection, otherwise a default certificate is used.
+ void SetupPeerconnectionWithLocalStream(
+ content::WebContents* tab,
+ std::string certificate_keygen_algorithm = "") const;
phoglund_chromium 2016/04/26 11:54:20 I was sure default arguments were banned, but they
hbos_chromium 2016/04/27 11:19:03 Acknowledged.
// Same as above but does not add the local stream.
- void SetupPeerconnectionWithoutLocalStream(content::WebContents* tab) const;
+ void SetupPeerconnectionWithoutLocalStream(
+ content::WebContents* tab,
+ std::string certificate_keygen_algorithm = "") const;
// Exchanges offers and answers between the peer connections in the
// respective tabs. Before calling this, you must have prepared peer

Powered by Google App Engine
This is Rietveld 408576698