WebRtcBrowserTest tests with RSA and ECDSA certificates.

chrome/browser/media/webrtc_browsertest_base.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/webrtc_browsertest_base.h"
 
 #include <stddef.h>
 
 #include "base/lazy_instance.h"
 #include "base/macros.h"
@@ skipping 37 matching lines @@
 const char WebRtcTestBase::kFailedWithPermissionDeniedError[] =
     "failed-with-error-PermissionDeniedError";
 const char WebRtcTestBase::kFailedWithPermissionDismissedError[] =
     "failed-with-error-PermissionDismissedError";
 const char WebRtcTestBase::kAudioVideoCallConstraints360p[] =
    "{audio: true, video: {mandatory: {minWidth: 640, maxWidth: 640, "
    " minHeight: 360, maxHeight: 360}}}";
 const char WebRtcTestBase::kAudioVideoCallConstraints720p[] =
    "{audio: true, video: {mandatory: {minWidth: 1280, maxWidth: 1280, "
    " minHeight: 720, maxHeight: 720}}}";
+const char WebRtcTestBase::kUseDefaultCertKeygen[] = "null";
+const char WebRtcTestBase::kUseDefaultVideoCodec[] = "";

[hbos_chromium, 2016/04/27 11:19:03]

I could default this to "null" too if you want before landing, but then we can't
distinguish between the value null and the string "null" (ofc that's a pointless
thing to be able to do) - see CreateLocalOffer.

[phoglund_chromium, 2016/04/27 13:23:12]

Hm, I think the video codec is used to construct perf bucket names, so don't do
that.

 
 namespace {
 
 base::LazyInstance<bool> hit_javascript_errors_ =
       LAZY_INSTANCE_INITIALIZER;
 
 // Intercepts all log messages. We always attach this handler but only look at
 // the results if the test requests so. Note that this will only work if the
 // WebrtcTestBase-inheriting test cases do not run in parallel (if they did they
 // would race to look at the log, which is global to all tests).
@@ skipping 228 matching lines @@
 std::string WebRtcTestBase::ExecuteJavascript(
     const std::string& javascript,
     content::WebContents* tab_contents) const {
   std::string result;
   EXPECT_TRUE(content::ExecuteScriptAndExtractString(
       tab_contents, javascript, &result));
   return result;
 }
 
 void WebRtcTestBase::SetupPeerconnectionWithLocalStream(
-    content::WebContents* tab) const {
-  SetupPeerconnectionWithoutLocalStream(tab);
+    content::WebContents* tab,
+    std::string certificate_keygen_algorithm) const {
+  SetupPeerconnectionWithoutLocalStream(tab, certificate_keygen_algorithm);
   EXPECT_EQ("ok-added", ExecuteJavascript("addLocalStream()", tab));
 }
 
 void WebRtcTestBase::SetupPeerconnectionWithoutLocalStream(
-    content::WebContents* tab) const {
+    content::WebContents* tab,
+    std::string certificate_keygen_algorithm) const {
+  if (certificate_keygen_algorithm.empty())

[phoglund_chromium, 2016/04/27 13:23:12]

Remove this if statement now that null is the default.

[hbos_chromium, 2016/04/27 15:09:08]

Done.

+    certificate_keygen_algorithm = "null";
+  std::string javascript = base::StringPrintf(
+      "preparePeerConnection(%s)", certificate_keygen_algorithm.c_str());
   EXPECT_EQ("ok-peerconnection-created",
-            ExecuteJavascript("preparePeerConnection()", tab));
+            ExecuteJavascript(javascript, tab));
 }
 
 std::string WebRtcTestBase::CreateLocalOffer(
       content::WebContents* from_tab,
       std::string default_video_codec) const {
   if (default_video_codec.empty())
     default_video_codec = "null";
   else
     default_video_codec = "'" + default_video_codec + "'";
   std::string javascript = base::StringPrintf(
@@ skipping 113 matching lines @@
 #endif
 }
 
 bool WebRtcTestBase::OnWin8() const {
 #if defined(OS_WIN)
   return base::win::GetVersion() > base::win::VERSION_WIN7;
 #else
   return false;
 #endif
 }