WebRtcBrowserTest tests with RSA and ECDSA certificates.

chrome/test/data/webrtc/peerconnection.js

 /**
  * Copyright 2014 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /**
  * The one and only peer connection in this page.
  * @private
  */
@@ skipping 10 matching lines @@
  * @private
  */
 var gHasSeenCryptoInSdp = 'no-crypto-seen';
 
 // Public interface to tests. These are expected to be called with
 // ExecuteJavascript invocations from the browser tests and will return answers
 // through the DOM automation controller.
 
 /**
  * Creates a peer connection. Must be called before most other public functions
- * in this file.
+ * in this file. Alternatively, see: |preparePeerConnectionWithCertificate|.
+ * @param {Object} keygenAlgorithm An |AlgorithmIdentifier| to be used as
+ * parameter to |RTCPeerConnection.generateCertificate|. The resulting
+ * certificate will be used by the peer connection.
  */
-function preparePeerConnection() {
+function preparePeerConnection(keygenAlgorithm) {
   if (gPeerConnection != null)
     throw failTest('creating peer connection, but we already have one.');
 
-  gPeerConnection = createPeerConnection_();
+  if (keygenAlgorithm == null) {

[jansson, 2016/04/27 07:07:30]

It's deemed best practice to use the strict equality operator in JS, e.g.
keygenAlgorithm === null. This also applies to inequality operator e.g. !==. The
reason is that it does not do any type conversion before comparing.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Equality_comparisons_...

[hbos_chromium, 2016/04/27 11:19:03]

Done. Also updated gPeerConnection comparison.

+    gPeerConnection = createPeerConnection_(null);
+    returnToTest('ok-peerconnection-created');
+  } else {
+    webkitRTCPeerConnection.generateCertificate(keygenAlgorithm).then(
+        function(certificate) {
+          preparePeerConnectionWithCertificate(certificate);
+        },
+        function() {
+          failTest('Certificate generation failed. keygenAlgorithm: ' +
+              JSON.stringify(keygenAlgorithm));
+        });
+  }
+}
+
+/**
+ * Creates a peer connection. Must be called before most other public functions
+ * in this file. Alternatively, see: |preparePeerConnection|.
+ * @param {!Object} certificate The |RTCCertificate| that will be used by the
+ * peer connection.
+ */
+function preparePeerConnectionWithCertificate(certificate) {

[phoglund_chromium, 2016/04/26 11:54:20]

There's no need to make this "public" in the javascript: make it an internal
helper function instead. You're not calling it from the c++ right? In fact, I'd
just inline it to line 46 and remove the gPeerConnection check.

[hbos_chromium, 2016/04/27 11:19:03]

It's not used but I was planning on probably using it in a different CL, but
I'll just move it back into its own function then.

[phoglund_chromium, 2016/04/27 13:23:12]

Yes, do it in the later CL in that case.

+  if (gPeerConnection != null)
+    throw failTest('creating peer connection, but we already have one.');
+  gPeerConnection = createPeerConnection_(
+      {iceServers:[], certificates:[certificate]});
   returnToTest('ok-peerconnection-created');
 }
 
 /**
  * Asks this page to create a local offer.
  *
  * Returns a string on the format ok-(JSON encoded session description).
  *
  * @param {!Object} constraints Any createOffer constraints.
  * @param {string} videoCodec If not null, promotes the specified codec to be
@@ skipping 208 matching lines @@
 /**
  * Returns
  */
 function hasSeenCryptoInSdp() {
   returnToTest(gHasSeenCryptoInSdp);
 }
 
 // Internals.
 
 /** @private */
-function createPeerConnection_() {
+function createPeerConnection_(rtcConfig) {
   try {
-    peerConnection = new RTCPeerConnection(null, {});
+    peerConnection = new RTCPeerConnection(rtcConfig, {});
   } catch (exception) {
     throw failTest('Failed to create peer connection: ' + exception);
   }
   peerConnection.onaddstream = addStreamCallback_;
   peerConnection.onremovestream = removeStreamCallback_;
   peerConnection.onicecandidate = iceCallback_;
   return peerConnection;
 }
 
 /** @private */
@@ skipping 41 matching lines @@
 function parseJson_(json) {
   // Escape since the \r\n in the SDP tend to get unescaped.
   jsonWithEscapedLineBreaks = json.replace(/\r\n/g, '\\r\\n');
   try {
     return JSON.parse(jsonWithEscapedLineBreaks);
   } catch (exception) {
     failTest('Failed to parse JSON: ' + jsonWithEscapedLineBreaks + ', got ' +
              exception);
   }
 }