Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 191713002: Remove unsupported WebRtc test on Android. (Closed)

Created:
6 years, 9 months ago by wjia(left Chromium)
Modified:
6 years, 9 months ago
Reviewers:
mcasas
CC:
chromium-reviews, craigdh+watch_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org
Visibility:
Public.

Description

Remove unsupported WebRtc test on Android. The test WebRtcGetUserMediaBrowserTest.TraceVideoCaptureDeviceAndroidPerformanceDuringGetUserMedia is not supported since content_browsertests always use faked capture device. BUG=181069 R=mcasas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255995

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : remove more code in video_capture_device_android.cc #

Patch Set 4 : remove more code in video_capture_device_android.cc #

Patch Set 5 : reload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M build/android/pylib/gtest/filter/content_browsertests_disabled View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/media/webrtc_getusermedia_browsertest.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M media/video/capture/android/video_capture_device_android.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wjia(left Chromium)
6 years, 9 months ago (2014-03-08 00:13:56 UTC) #1
mcasas
On 2014/03/08 00:13:56, wjia wrote: Thanks for picking this up! IINM, the tracing in [1] ...
6 years, 9 months ago (2014-03-10 08:10:54 UTC) #2
wjia(left Chromium)
On 2014/03/10 08:10:54, mcasas wrote: > On 2014/03/08 00:13:56, wjia wrote: > > Thanks for ...
6 years, 9 months ago (2014-03-10 16:55:08 UTC) #3
mcasas
On 2014/03/10 16:55:08, wjia wrote: > On 2014/03/10 08:10:54, mcasas wrote: > > On 2014/03/08 ...
6 years, 9 months ago (2014-03-10 18:27:34 UTC) #4
wjia(left Chromium)
6 years, 9 months ago (2014-03-10 18:40:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r255995 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698