Issue 1917093004: depot_tools: only add mock infra_paths when test data is enabled

Issue 1917093004: depot_tools: only add mock infra_paths when test data is enabled (Closed)

Created:
4 years, 7 months ago by Paweł Hajdan Jr.

Modified:
4 years, 7 months ago

Reviewers:
Sergiy Byelozyorov, tandrii(chromium), M-A Ruel, Michael Achenbach

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

More Reviews

Description

depot_tools: only add mock infra_paths when test data is enabled BUG=chromium:605919 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300193

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	recipe_modules/infra_paths/api.py	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 12 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917093004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917093004/1

4 years, 7 months ago (2016-04-26 14:22:25 UTC) #7

commit-bot: I haz the power

Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300193

4 years, 7 months ago (2016-04-26 14:25:02 UTC) #9

tandrii(chromium)

4 years, 7 months ago (2016-04-26 18:51:49 UTC) #12

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1919093004/ by tandrii@chromium.org.

The reason for reverting is: breaks skia bots.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages