Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1917083002: Move gfx::Display/Screen to display::Display/Screen in ui/base (Closed)

Created:
4 years, 8 months ago by oshima
Modified:
4 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, sadrul, derat+watch_chromium.org, jshin+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move gfx::Display/Screen to display::Display/Screen in ui/base BUG=597761 Committed: https://crrev.com/e30b32d5a55d5d6ca46c90fe8d9abd2c0eb56995 Cr-Commit-Position: refs/heads/master@{#390700}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -64 lines) Patch
M ui/base/cursor/cursor_loader.h View 3 chunks +5 lines, -7 lines 0 comments Download
M ui/base/cursor/cursor_loader_x11.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/cursor/cursor_loader_x11.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/base/cursor/cursor_loader_x11_unittest.cc View 2 chunks +9 lines, -16 lines 0 comments Download
M ui/base/cursor/cursor_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/cursor/cursor_util.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M ui/base/cursor/image_cursors.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/cursor/image_cursors.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/l10n/l10n_util_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/layout.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M ui/base/resource/resource_bundle_auralinux.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M ui/base/x/x11_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917083002/1
4 years, 8 months ago (2016-04-26 01:16:57 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 02:49:35 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917083002/20001
4 years, 8 months ago (2016-04-26 06:14:12 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 07:06:02 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917083002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917083002/40001
4 years, 7 months ago (2016-04-26 22:39:35 UTC) #12
oshima
4 years, 7 months ago (2016-04-26 22:59:35 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-26 23:35:39 UTC) #16
oshima
friendly ping
4 years, 7 months ago (2016-04-28 21:15:26 UTC) #17
oshima
sadrul@,can you review this? Thanks
4 years, 7 months ago (2016-04-29 17:04:23 UTC) #19
sadrul
lgtm
4 years, 7 months ago (2016-04-29 17:12:40 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917083002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917083002/40001
4 years, 7 months ago (2016-04-29 17:13:40 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 7 months ago (2016-04-29 18:17:42 UTC) #23
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:27:26 UTC) #24
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e30b32d5a55d5d6ca46c90fe8d9abd2c0eb56995
Cr-Commit-Position: refs/heads/master@{#390700}

Powered by Google App Engine
This is Rietveld 408576698