unique_ptr_migration: clean up references to scoped_ptr as of r389721

unique_ptr_migration: clean up references to scoped_ptr as of r389721

BUG=554298
R=thestig@chromium.org
TBR=brettw@chromium.org

Committed: https://crrev.com/18ec0b546913970cbe50d6b58e70e013550aed65
Cr-Commit-Position: refs/heads/master@{#389848}

[dcheng, 2016-04-26 08:16:55]

Pretty straightforward, I hope. Hopefully it passes the trybots.

I manually checked all the headers to see if they made sense, but the diffs
themselves might not make sense in isolation without looking at related headers
/ the headers that are already present, etc.

https://codereview.chromium.org/1917053003/diff/1/chrome_elf/blacklist/test/b...
File chrome_elf/blacklist/test/blacklist_test.cc (left):

https://codereview.chromium.org/1917053003/diff/1/chrome_elf/blacklist/test/b...
chrome_elf/blacklist/test/blacklist_test.cc:14: #include
"base/memory/scoped_ptr.h"
For deletion-only changes, it's usually because the file already has a <memory>
include.

https://codereview.chromium.org/1917053003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/browser_compositor_view_mac.h (right):

https://codereview.chromium.org/1917053003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/browser_compositor_view_mac.h:8: #include <memory>
IWYU fixes.

https://codereview.chromium.org/1917053003/diff/1/content/renderer/mus/compos...
File content/renderer/mus/compositor_mus_connection_unittest.cc (right):

https://codereview.chromium.org/1917053003/diff/1/content/renderer/mus/compos...
content/renderer/mus/compositor_mus_connection_unittest.cc:471:
std::unique_ptr<base::Callback<void(EventResult)>> ack_callback(
No need to add <memory> since it's already included.

[Lei Zhang, 2016-04-26 18:00:44]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2016-04-26 18:00:45]

lgtm

[dcheng, 2016-04-26 18:02:17]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-26 18:02:25]

Description was changed from

==========
unique_ptr_migration: clean up references to scoped_ptr as of r389721

BUG=554298
R=danakj@chromium.org
TBR=brettw@chromium.org
==========

to

==========
unique_ptr_migration: clean up references to scoped_ptr as of r389721

BUG=554298
R=thestig@chromium.org
TBR=brettw@chromium.org
==========

[commit-bot: I haz the power, 2016-04-26 18:02:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1917053003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1917053003/40001

[danakj, 2016-04-26 18:15:54]

LGTM

Maybe we want a PRESUBMIT ban for scoped_ptr until we delete it, if we find
ourselves racing with people adding new ones. Hopefully we don't.

[dcheng, 2016-04-26 18:32:33]

On 2016/04/26 at 18:15:54, danakj wrote:
> LGTM
> 
> Maybe we want a PRESUBMIT ban for scoped_ptr until we delete it, if we find
ourselves racing with people adding new ones. Hopefully we don't.

It's probably OK. If it proves too painful, I'll add the PRESUBMIT (but I
otherwise anticipate removing it today)

[commit-bot: I haz the power, 2016-04-26 19:29:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-26 19:30:52]

Description was changed from

==========
unique_ptr_migration: clean up references to scoped_ptr as of r389721

BUG=554298
R=thestig@chromium.org
TBR=brettw@chromium.org
==========

to

==========
unique_ptr_migration: clean up references to scoped_ptr as of r389721

BUG=554298
R=thestig@chromium.org
TBR=brettw@chromium.org

Committed: https://crrev.com/18ec0b546913970cbe50d6b58e70e013550aed65
Cr-Commit-Position: refs/heads/master@{#389848}
==========

[commit-bot: I haz the power, 2016-04-26 19:30:54]

Patchset 3 (id:??) landed as
https://crrev.com/18ec0b546913970cbe50d6b58e70e013550aed65
Cr-Commit-Position: refs/heads/master@{#389848}