Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: chrome/browser/background/background_application_list_model_unittest.cc

Issue 1917043006: Disable BackgroundApplicationListModelTest.ExplicitTest everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/background/background_application_list_model_unittest.cc
diff --git a/chrome/browser/background/background_application_list_model_unittest.cc b/chrome/browser/background/background_application_list_model_unittest.cc
index 9aababcba8ecad44396b89d075a1cc4083312f17..103d9e27067c8a6afee42d685d8226b9402e9287 100644
--- a/chrome/browser/background/background_application_list_model_unittest.cc
+++ b/chrome/browser/background/background_application_list_model_unittest.cc
@@ -139,14 +139,11 @@ void RemoveBackgroundPermission(ExtensionService* service,
// Crashes on Mac tryslaves.
// http://crbug.com/165458
-#if defined(OS_MACOSX) || defined(OS_LINUX)
-#define MAYBE_ExplicitTest DISABLED_ExplicitTest
-#else
-#define MAYBE_ExplicitTest ExplicitTest
-#endif
+// Also crashes on Windows under Dr. Memory (https://crbug.com/606779),
+// presumably broken on all platforms.
// With minimal test logic, verifies behavior over an explicit set of
// extensions, of which some are Background Apps and others are not.
-TEST_F(BackgroundApplicationListModelTest, MAYBE_ExplicitTest) {
+TEST_F(BackgroundApplicationListModelTest, DISABLED_ExplicitTest) {
InitializeAndLoadEmptyExtensionService();
ASSERT_TRUE(service()->is_ready());
ASSERT_TRUE(registry()->enabled_extensions().is_empty());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698