Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Issue 1917043004: Flip remaining non-lkgr linux memory bots to GN. (Closed)

Created:
4 years, 8 months ago by Dirk Pranke
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip remaining non-lkgr linux memory bots to GN. Also, it turns out that I had missed the chromium.memory waterfall completely, so add in entries for that. R=brettw@chromium.org BUG=605732 Committed: https://crrev.com/8510319c1fbb784edeb11ebdb522b00c9a851b1d Cr-Commit-Position: refs/heads/master@{#389909}

Patch Set 1 : sorting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -18 lines) Patch
M tools/mb/mb_config.pyl View 7 chunks +44 lines, -18 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Dirk Pranke
4 years, 8 months ago (2016-04-26 02:19:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917043004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917043004/20001
4 years, 8 months ago (2016-04-26 02:20:49 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 03:44:16 UTC) #6
brettw
lgtm
4 years, 8 months ago (2016-04-26 04:56:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917043004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917043004/20001
4 years, 8 months ago (2016-04-26 21:55:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-04-26 22:03:29 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8510319c1fbb784edeb11ebdb522b00c9a851b1d Cr-Commit-Position: refs/heads/master@{#389909}
4 years, 8 months ago (2016-04-26 22:05:50 UTC) #12
Dirk Pranke
4 years, 8 months ago (2016-04-26 22:59:17 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/1924553004/ by dpranke@chromium.org.

The reason for reverting is: Broke the MSAN builder:

https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20....

Powered by Google App Engine
This is Rietveld 408576698