Added shaderc, glslang, and SPIRV-Tools to third_party.

Added shaderc, glslang, and SPIRV-Tools to third_party.

This CL primarily adds shaderc into third_party. The library also
depends on glsland and SPIRV-Tools which is why they are also added
as third_party repositories.

R=thakis@chromium.org
BUG=582558, 608468
Committed: https://crrev.com/b780ac58cfda43ae83ccb684c3f717cdeb827969
Cr-Commit-Position: refs/heads/master@{#392667}

[David Yen, 2016-04-26 01:01:02]

Description was changed from

==========
Added shaderc, glslang, and SPIRV-Tools to third_party.

This CL primarily adds shaderc into third_party. The library also
depends on glsland and SPIRV-Tools which is why they are also added
as third_party repositories.

R=piman@chromium.org
BUG=582558
==========

to

==========
Added shaderc, glslang, and SPIRV-Tools to third_party.

This CL primarily adds shaderc into third_party. The library also
depends on glsland and SPIRV-Tools which is why they are also added
as third_party repositories.

R=piman@chromium.org
BUG=582558
==========

[David Yen, 2016-04-26 01:01:03]

dyen@chromium.org changed reviewers:
+ thiakis@chromium.org
- piman@chromium.org

[David Yen, 2016-04-26 01:01:25]

dyen@chromium.org changed reviewers:
+ thakis@chromium.org
- thiakis@chromium.org

[David Yen, 2016-04-26 01:01:36]

Description was changed from

==========
Added shaderc, glslang, and SPIRV-Tools to third_party.

This CL primarily adds shaderc into third_party. The library also
depends on glsland and SPIRV-Tools which is why they are also added
as third_party repositories.

R=piman@chromium.org
BUG=582558
==========

to

==========
Added shaderc, glslang, and SPIRV-Tools to third_party.

This CL primarily adds shaderc into third_party. The library also
depends on glsland and SPIRV-Tools which is why they are also added
as third_party repositories.

R=thakis@chromium.org
BUG=582558
==========

[David Yen, 2016-04-26 01:02:57]

PTAL. I'm trying to add shaderc but it depends on both SPIRV-Tools and glslang.
Is it ok to add all 3 repositories in 1 CL?

Note this is sort of a placeholder because it is pending infra to mirror the git
repositories. Once that is done I will also email legal/security for review.

[David Yen, 2016-04-29 00:23:42]

The chromium mirrors have been created, I have an LGTM from legal and am pending
a security review.

I will put this through the trybots now.

[Robert Sesek, 2016-04-29 15:19:22]

rsesek@chromium.org changed reviewers:
+ rsesek@chromium.org

[Robert Sesek, 2016-04-29 15:19:23]

lgtm from security

[Nico, 2016-04-29 15:23:04]

lgtm

[David Yen, 2016-04-29 15:37:01]

The CQ bit was checked by dyen@chromium.org

[commit-bot: I haz the power, 2016-04-29 15:37:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1917043003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1917043003/40001

[commit-bot: I haz the power, 2016-04-29 17:03:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 17:03:58]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Yen, 2016-04-29 17:45:00]

On 2016/04/29 17:03:58, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

I'll upstream the missing license headers

[David Yen, 2016-05-02 20:41:10]

Description was changed from

==========
Added shaderc, glslang, and SPIRV-Tools to third_party.

This CL primarily adds shaderc into third_party. The library also
depends on glsland and SPIRV-Tools which is why they are also added
as third_party repositories.

R=thakis@chromium.org
BUG=582558
==========

to

==========
Added shaderc, glslang, and SPIRV-Tools to third_party.

This CL primarily adds shaderc into third_party. The library also
depends on glsland and SPIRV-Tools which is why they are also added
as third_party repositories.

R=thakis@chromium.org
BUG=582558, 608468
==========

[David Yen, 2016-05-02 20:43:11]

dyen@chromium.org changed reviewers:
+ phajdan.jr@chromium.org, thestig@chromium.org

[David Yen, 2016-05-02 20:43:11]

I've upstreamed the missing shaderc license headers, the glslang one is in the
process of being upstreamed.

I've created an issue to track the glslang license issue, in the meantime I've
added the repo to the license white list.

+phajdan.jr@ for license check review since thestig@ is out of office.

[piman, 2016-05-02 22:15:30]

piman@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2016-05-02 22:15:31]

lgtm

[Paweł Hajdan Jr., 2016-05-04 14:11:44]

Looks like the pull request to fix checklicenses issues has been merged. Is the
whitelist still necessary with latest code?

[David Yen, 2016-05-04 20:12:58]

On 2016/05/04 14:11:44, Paweł Hajdan Jr. wrote:
> Looks like the pull request to fix checklicenses issues has been merged. Is
the
> whitelist still necessary with latest code?

The head is still being blocked by an issue with tests, it will be fixed once
this pull request lands:

https://github.com/KhronosGroup/glslang/pull/257#issuecomment-216985249

I'll be out of office for a week so it's probably better to wait at this point,
I'll revert the whitelist.

[David Yen, 2016-05-10 17:43:31]

The CQ bit was checked by dyen@chromium.org

[David Yen, 2016-05-10 17:43:32]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
thakis@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1917043003/#ps120001
(title: "updated glslang ref, removed whitelist entry")

[commit-bot: I haz the power, 2016-05-10 17:44:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1917043003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1917043003/120001

[commit-bot: I haz the power, 2016-05-10 19:02:55]

Description was changed from

==========
Added shaderc, glslang, and SPIRV-Tools to third_party.

This CL primarily adds shaderc into third_party. The library also
depends on glsland and SPIRV-Tools which is why they are also added
as third_party repositories.

R=thakis@chromium.org
BUG=582558, 608468
==========

to

==========
Added shaderc, glslang, and SPIRV-Tools to third_party.

This CL primarily adds shaderc into third_party. The library also
depends on glsland and SPIRV-Tools which is why they are also added
as third_party repositories.

R=thakis@chromium.org
BUG=582558, 608468
==========

[commit-bot: I haz the power, 2016-05-10 19:02:56]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-05-10 19:04:39]

Description was changed from

==========
Added shaderc, glslang, and SPIRV-Tools to third_party.

This CL primarily adds shaderc into third_party. The library also
depends on glsland and SPIRV-Tools which is why they are also added
as third_party repositories.

R=thakis@chromium.org
BUG=582558, 608468
==========

to

==========
Added shaderc, glslang, and SPIRV-Tools to third_party.

This CL primarily adds shaderc into third_party. The library also
depends on glsland and SPIRV-Tools which is why they are also added
as third_party repositories.

R=thakis@chromium.org
BUG=582558, 608468

Committed: https://crrev.com/b780ac58cfda43ae83ccb684c3f717cdeb827969
Cr-Commit-Position: refs/heads/master@{#392667}
==========

[commit-bot: I haz the power, 2016-05-10 19:04:40]

Patchset 7 (id:??) landed as
https://crrev.com/b780ac58cfda43ae83ccb684c3f717cdeb827969
Cr-Commit-Position: refs/heads/master@{#392667}