ScreenCapture for Android phase1, part I

content/browser/media/capture/screen_capture_device_android.h

Index: content/browser/media/capture/screen_capture_device_android.h
diff --git a/content/browser/media/capture/screen_capture_device_android.h b/content/browser/media/capture/screen_capture_device_android.h
new file mode 100644
index 0000000000000000000000000000000000000000..1423df5444681f40e6c820e9e9d8bc6f00f87314
--- /dev/null
+++ b/content/browser/media/capture/screen_capture_device_android.h
@@ -0,0 +1,44 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_MEDIA_CAPTURE_SCREEN_CAPTURE_DEVICE_ANDROID_H_
+#define CONTENT_BROWSER_MEDIA_CAPTURE_SCREEN_CAPTURE_DEVICE_ANDROID_H_
+
+#include <memory>
+
+#include "content/public/browser/power_save_blocker.h"
+#include "media/capture/content/screen_capture_device_core.h"
+#include "media/capture/video/video_capture_device.h"
+
+namespace content {
+
+class ScreenCaptureDeviceAndroid : public media::VideoCaptureDevice {

[mcasas, 2016/05/19 19:11:39]

Class comments? Sth like: SCDAndroid is a forwarder to 
SCDCore while keeping the Power Saving from kicking in
between AllocateAndStart() and StopAndDeallocate().

[braveyao, 2016/05/20 22:27:24]

Done.

+ public:
+  ScreenCaptureDeviceAndroid();
+  ~ScreenCaptureDeviceAndroid() override;
+
+  static std::unique_ptr<media::VideoCaptureDevice> Create();
+
+  // VideoCaptureDevice implementation.
+  void AllocateAndStart(const media::VideoCaptureParams& params,
+                        std::unique_ptr<Client> client) override;
+  void StopAndDeAllocate() override;
+  void RequestRefreshFrame() override;
+
+ private:
+  std::unique_ptr<media::ScreenCaptureDeviceCore> core_;

[mcasas, 2016/05/19 19:11:40]

const. Actually just make it a member:
media::ScreenCaptureDeviceCore core_;
since anyway creating ScreenCaptureDeviceAndroid
already implies we want to go ahead with the capture,
there's no benefit in initializing on the heap.

[braveyao, 2016/05/20 22:27:25]

Done the const part. 
Not quite understand the rest. Just keep same as other capture implementations.

[mcasas, 2016/05/23 18:19:55]

I'm saying that you should make it
media::ScreenCaptureDeviceCore core_;
instead of allocating it on constructor.

[braveyao, 2016/05/24 00:03:26]

Done.

+
+  // The capture device.

[mcasas, 2016/05/19 19:11:40]

Remove superfluous comment.

[braveyao, 2016/05/20 22:27:24]

Done.

+  std::unique_ptr<media::VideoCaptureDevice> video_capture_device_;

[mcasas, 2016/05/19 19:11:40]

Unused member?? Remove.

[braveyao, 2016/05/20 22:27:24]

Done.

+
+  // TODO(jiayl): Remove power_save_blocker_ when there is an API to keep the
+  // screen from sleeping for the drive-by web.

[mcasas, 2016/05/19 19:11:40]

I'm surprised you add comments for a 3rd person :)
Escape variable names in comments using ||.
TODOs should have a crbug.com

[braveyao, 2016/05/20 22:27:24]

This is merely from aura_window_capture_machine implementation. No idea what's
the plan here. So just remove the comment.

+  std::unique_ptr<PowerSaveBlocker> power_save_blocker_;
+
+  DISALLOW_COPY_AND_ASSIGN(ScreenCaptureDeviceAndroid);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_MEDIA_CAPTURE_SCREEN_CAPTURE_DEVICE_ANDROID_H_