ScreenCapture for Android phase1, part I

media/capture/content/android/screen_capture_device_android.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "media/capture/content/android/screen_capture_device_android.h"
+
+#include "base/logging.h"
+#include "base/memory/ptr_util.h"
+#include "media/capture/content/android/screen_capture_machine_android.h"
+
+namespace media {
+
+ScreenCaptureDeviceAndroid::ScreenCaptureDeviceAndroid() {
+  ScreenCaptureMachineAndroid* machine = new ScreenCaptureMachineAndroid();
+  core_.reset(new ScreenCaptureDeviceCore(base::WrapUnique(machine)));

[mcasas, 2016/04/27 01:19:27]

Make |core_| const and initialize it in the
initializer list:
core_(new ScreenCaptureDeviceCore(
    make_unique_ptr(new ScreenCaptureMachineAndroid());

[braveyao, 2016/05/04 18:49:41]

Done.
Anyway I think it's also good to stay in same way as desktop capture aura does.

+}
+
+ScreenCaptureDeviceAndroid::~ScreenCaptureDeviceAndroid() {
+  DVLOG(2) << "ScreenCaptureDeviceAndroid@" << this << " destroying.";
+}
+
+void ScreenCaptureDeviceAndroid::AllocateAndStart(
+    const media::VideoCaptureParams& params,
+    std::unique_ptr<Client> client) {
+  DVLOG(1) << "Allocating " << params.requested_format.frame_size.ToString();
+  core_->AllocateAndStart(params, std::move(client));
+}
+
+void ScreenCaptureDeviceAndroid::StopAndDeAllocate() {
+  core_->StopAndDeAllocate();

[mcasas, 2016/04/27 01:19:27]

ScreenCaptureDeviceAndroid is just a forwarder
class, I suggest removing it altogether and
using ScreenCaptureDeviceCore directly instead,
unless I'm missing something.

[braveyao, 2016/05/04 18:49:41]

Done. Move it to Content as a front, also for the purpose to start
power_save_block.

+}
+
+}  // namespace media