Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1916973005: Update OS version checks. (Closed)

Created:
4 years, 8 months ago by Jamie
Modified:
4 years, 8 months ago
Reviewers:
joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update OS version checks. This CL updates the strings displayed in the webapp when downloading the host installer and updates the Wix script to remove support for Windows XP. BUG=601504 Committed: https://crrev.com/037cdd7bc79852e3f09ea2859fc7ec7b55e274b5 Cr-Commit-Position: refs/heads/master@{#389940}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -25 lines) Patch
M remoting/host/installer/win/chromoting.wxs View 3 chunks +4 lines, -23 lines 2 comments Download
M remoting/resources/remoting_strings.grd View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jamie
PTAL. I'm not sure the trybots have the Wix toolchain installed, so if you could ...
4 years, 8 months ago (2016-04-26 21:01:01 UTC) #2
joedow
lgtm. I built this locally and installed it on a Win7 machine and it worked ...
4 years, 8 months ago (2016-04-26 22:06:19 UTC) #3
Jamie
FYI https://codereview.chromium.org/1916973005/diff/1/remoting/host/installer/win/chromoting.wxs File remoting/host/installer/win/chromoting.wxs (right): https://codereview.chromium.org/1916973005/diff/1/remoting/host/installer/win/chromoting.wxs#newcode97 remoting/host/installer/win/chromoting.wxs:97: Message="$(var.ChromotingHost) is only supported on Windows 7 and ...
4 years, 8 months ago (2016-04-26 22:36:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916973005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916973005/1
4 years, 8 months ago (2016-04-26 22:37:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 23:29:09 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 23:30:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/037cdd7bc79852e3f09ea2859fc7ec7b55e274b5
Cr-Commit-Position: refs/heads/master@{#389940}

Powered by Google App Engine
This is Rietveld 408576698