[chromecast] Delete MediaMessageLoop.

[chromecast] Delete MediaMessageLoop.

BUG=594234
Committed: https://crrev.com/2380710ed31462aa62f7d5cd04d8e8e728b8f495
Cr-Commit-Position: refs/heads/master@{#389890}

[alokp, 2016-04-26 18:36:11]

alokp@chromium.org changed reviewers:
+ halliwell@chromium.org

[halliwell, 2016-04-26 19:08:37]

lgtm with comments

https://codereview.chromium.org/1916973004/diff/1/chromecast/browser/cast_bro...
File chromecast/browser/cast_browser_main_parts.cc (right):

https://codereview.chromium.org/1916973004/diff/1/chromecast/browser/cast_bro...
chromecast/browser/cast_browser_main_parts.cc:264: #if defined(OS_ANDROID)
NOTREACHED?

https://codereview.chromium.org/1916973004/diff/1/chromecast/browser/cast_bro...
chromecast/browser/cast_browser_main_parts.cc:268: media_thread_.reset(new
base::Thread("CmaThread"));
Should we call it just "MediaThread" now?

[alokp, 2016-04-26 20:05:44]

https://codereview.chromium.org/1916973004/diff/1/chromecast/browser/cast_bro...
File chromecast/browser/cast_browser_main_parts.cc (right):

https://codereview.chromium.org/1916973004/diff/1/chromecast/browser/cast_bro...
chromecast/browser/cast_browser_main_parts.cc:264: #if defined(OS_ANDROID)
On 2016/04/26 19:08:36, halliwell wrote:
> NOTREACHED?

I am not sure if this is called on Android or not. Let me land it like this. I
will do a try run with NOTREACHED when cherry-picking.

https://codereview.chromium.org/1916973004/diff/1/chromecast/browser/cast_bro...
chromecast/browser/cast_browser_main_parts.cc:268: media_thread_.reset(new
base::Thread("CmaThread"));
On 2016/04/26 19:08:36, halliwell wrote:
> Should we call it just "MediaThread" now?

How about CastMediaThread?

[halliwell, 2016-04-26 20:10:26]

https://codereview.chromium.org/1916973004/diff/1/chromecast/browser/cast_bro...
File chromecast/browser/cast_browser_main_parts.cc (right):

https://codereview.chromium.org/1916973004/diff/1/chromecast/browser/cast_bro...
chromecast/browser/cast_browser_main_parts.cc:264: #if defined(OS_ANDROID)
On 2016/04/26 20:05:44, alokp wrote:
> On 2016/04/26 19:08:36, halliwell wrote:
> > NOTREACHED?
> 
> I am not sure if this is called on Android or not. Let me land it like this. I
> will do a try run with NOTREACHED when cherry-picking.

That's true, it could be called when constructing some objects just to reduce
amount of conditional compilation.

https://codereview.chromium.org/1916973004/diff/1/chromecast/browser/cast_bro...
chromecast/browser/cast_browser_main_parts.cc:268: media_thread_.reset(new
base::Thread("CmaThread"));
On 2016/04/26 20:05:44, alokp wrote:
> On 2016/04/26 19:08:36, halliwell wrote:
> > Should we call it just "MediaThread" now?
> 
> How about CastMediaThread?

sgtm

[alokp, 2016-04-26 20:16:50]

The CQ bit was checked by alokp@chromium.org

[alokp, 2016-04-26 20:16:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/1916973004/#ps20001
(title: "cmathread -> castmediathread")

[commit-bot: I haz the power, 2016-04-26 20:17:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916973004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916973004/20001

[commit-bot: I haz the power, 2016-04-26 21:17:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-26 21:20:11]

Description was changed from

==========
[chromecast] Delete MediaMessageLoop.

BUG=594234
==========

to

==========
[chromecast] Delete MediaMessageLoop.

BUG=594234

Committed: https://crrev.com/2380710ed31462aa62f7d5cd04d8e8e728b8f495
Cr-Commit-Position: refs/heads/master@{#389890}
==========

[commit-bot: I haz the power, 2016-04-26 21:20:12]

Patchset 2 (id:??) landed as
https://crrev.com/2380710ed31462aa62f7d5cd04d8e8e728b8f495
Cr-Commit-Position: refs/heads/master@{#389890}