Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1916973003: Revert of [Media Router Tests] Add tests for MediaRouterFactory. (Closed)

Created:
4 years, 8 months ago by Marc Treib
Modified:
4 years, 8 months ago
Reviewers:
mark a. foltz, imcheng
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, media-router+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Media Router Tests] Add tests for MediaRouterFactory. (patchset #4 id:60001 of https://codereview.chromium.org/1877273002/ ) Reason for revert: Breaks the build: https://build.chromium.org/p/chromium.linux/builders/Android%20Builder/builds/65239 Original issue's description: > [Media Router Tests] Add tests for MediaRouterFactory. > > Committed: https://crrev.com/4f04fcb749ed895a6d5baa72a0ff164fa27589e6 > Cr-Commit-Position: refs/heads/master@{#389721} TBR=mfoltz@chromium.org,imcheng@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/c98377b9a9222a986f86298acd36a6e16551298d Cr-Commit-Position: refs/heads/master@{#389722}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -78 lines) Patch
M chrome/browser/media/router/media_router_factory.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/media/router/media_router_factory.cc View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/browser/media/router/media_router_factory_unittest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Marc Treib
Created Revert of [Media Router Tests] Add tests for MediaRouterFactory.
4 years, 8 months ago (2016-04-26 07:55:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916973003/1
4 years, 8 months ago (2016-04-26 07:55:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 07:56:18 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 07:57:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c98377b9a9222a986f86298acd36a6e16551298d
Cr-Commit-Position: refs/heads/master@{#389722}

Powered by Google App Engine
This is Rietveld 408576698