Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1916973002:
Gclient: Don't check if repository is clean if --force is passed in (Closed)
|
Created:
4 years, 8 months ago by hinoka Modified:
4 years, 8 months ago CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionGclient: Don't check if repository is clean if --force is passed in
Instead just do a git checkout --force, since there are some states that reset cannot fix.
BUG=606420
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300176
Patch Set 1 #Patch Set 2 : Plan B #Messages
Total messages: 22 (11 generated)
Message was sent while issue was closed.
hinoka@google.com changed reviewers: + hinoka@google.com
Message was sent while issue was closed.
This approach doesn't work, trying something else
Message was sent while issue was closed.
Description was changed from ========== Gclient: clean out files if any are left after --reset HARD BUG=606420 ========== to ========== Gclient: clean out files if any are left after --reset HARD BUG=606420 ==========
Description was changed from ========== Gclient: clean out files if any are left after --reset HARD BUG=606420 ========== to ========== Gclient: Don't check if repository is clean if --force is passed in Instead just do a git checkout --force, since there are some states that reset cannot fix. BUG=606420 ==========
Ok this approach works, verified locally.
hinoka@google.com changed reviewers: + iannucci@chromium.org
hinoka@google.com changed reviewers: + dnj@chromium.org
lgtm
The CQ bit was checked by hinoka@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916973002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)
The CQ bit was checked by hinoka@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916973002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)
The CQ bit was checked by hinoka@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916973002/20001
Message was sent while issue was closed.
Description was changed from ========== Gclient: Don't check if repository is clean if --force is passed in Instead just do a git checkout --force, since there are some states that reset cannot fix. BUG=606420 ========== to ========== Gclient: Don't check if repository is clean if --force is passed in Instead just do a git checkout --force, since there are some states that reset cannot fix. BUG=606420 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300176 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300176 |
