Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 1916943002: Show correct part of truncated text before ellipsis in contrary flow (Closed)

Created:
4 years, 8 months ago by rhogan
Modified:
4 years, 7 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@604144
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show correct part of truncated text before ellipsis in contrary flow When text is in a contrary-direction flow then ensure we show the start of the text that we are truncating rather than the end of it. BUG=155836 Committed: https://crrev.com/e168de8aa7dd678277ca1e8df6cc8fe6b418acdf Cr-Commit-Position: refs/heads/master@{#390874}

Patch Set 1 #

Patch Set 2 : Updated #

Patch Set 3 : Updated #

Patch Set 4 : Updated #

Patch Set 5 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -25 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-ltr-text-in-ltr-flow.html View 1 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-ltr-text-in-rtl-flow.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-rtl-text-in-ltr-flow.html View 1 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/ellipsis-rtl-text-in-rtl-flow.html View 1 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-expected.png View 1 2 3 4 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-strict-expected.png View 1 2 3 4 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-input-expected.png View 1 2 3 4 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-ltr-flow-expected.png View 1 2 3 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-ltr-flow-expected.txt View 1 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-rtl-flow-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-ltr-text-in-rtl-flow-expected.txt View 1 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-ltr-flow-expected.png View 1 2 3 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-ltr-flow-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-rtl-flow-expected.png View 1 2 3 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-rtl-text-in-rtl-flow-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/emphasis-ellipsis-complextext-expected.png View 1 2 3 4 Binary file 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 1 2 2 chunks +6 lines, -21 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
rhogan
4 years, 7 months ago (2016-04-27 19:07:04 UTC) #4
eae
Thank you for fixing this! LGTM
4 years, 7 months ago (2016-04-28 01:17:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916943002/40001
4 years, 7 months ago (2016-04-28 01:18:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/218877)
4 years, 7 months ago (2016-04-28 03:04:01 UTC) #9
eae
Still LGTM :)
4 years, 7 months ago (2016-05-01 14:15:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916943002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916943002/80001
4 years, 7 months ago (2016-05-01 21:49:09 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-01 21:54:36 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 21:56:17 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e168de8aa7dd678277ca1e8df6cc8fe6b418acdf
Cr-Commit-Position: refs/heads/master@{#390874}

Powered by Google App Engine
This is Rietveld 408576698