LayoutTests/compositing/squashing/squash-above-fixed-3.html - Issue 191693002: Delay scrollContents until the next paint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/compositing/squashing/squash-above-fixed-3.html

Issue 191693002: Delay scrollContents until the next paint (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix layout tests Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/compositing/squashing/squash-above-fixed-1.html ('K') | « LayoutTests/compositing/squashing/squash-above-fixed-2.html ('k') | LayoutTests/fast/repaint/absolute-position-changed.html » ('j') | LayoutTests/fast/repaint/overflow-auto-in-overflow-auto-scrolled.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/compositing/squashing/squash-above-fixed-3.html

diff --git a/LayoutTests/compositing/squashing/squash-above-fixed-3.html b/LayoutTests/compositing/squashing/squash-above-fixed-3.html

index d938882cdd6df7df50f7d0330b36e3ff7d671748..92dd8e9f76146fd71d607181811f4e7213f0dae5 100644

--- a/LayoutTests/compositing/squashing/squash-above-fixed-3.html

+++ b/LayoutTests/compositing/squashing/squash-above-fixed-3.html

@@ -1,6 +1,7 @@

<!DOCTYPE html>

<html>

<head>

+<script src="../../resources/run-after-display.js"></script>

<style>

#backgroundFixed {

@@ -59,8 +60,10 @@ body {

</style>

- if (window.testRunner)

+ if (window.testRunner) {

testRunner.dumpAsText();

+ testRunner.waitUntilDone();

+ }

if (window.internals)

internals.settings.setLayerSquashingEnabled(true);

@@ -76,17 +79,24 @@ body {

// Case 2

window.internals.startTrackingRepaints(document);

window.scrollTo(0, 10);

- document.getElementById('Case2').textContent = window.internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_REPAINT_RECTS);

- window.internals.stopTrackingRepaints(document);

- // Case 3

- window.internals.startTrackingRepaints(document);

- window.scrollTo(0, 110);

- document.getElementById('Case3').textContent = window.internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_REPAINT_RECTS);

- window.internals.stopTrackingRepaints(document);

- // Display the test results only after test is done so that it does not affect repaint rect results.

- document.getElementById('testResults').style.display = "block";

+ runAfterDisplay(function() {

+ document.getElementById('Case2').textContent = window.internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_REPAINT_RECTS);

+ window.internals.stopTrackingRepaints(document);

+ // Case 3

+ window.internals.startTrackingRepaints(document);

+ window.scrollTo(0, 110);

+ runAfterDisplay(function() {

+ document.getElementById('Case3').textContent = window.internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_REPAINT_RECTS);

+ window.internals.stopTrackingRepaints(document);

+ // Display the test results only after test is done so that it does not affect repaint rect results.

+ document.getElementById('testResults').style.display = "block";

+ if (window.testRunner)

+ testRunner.notifyDone();

+ });

}

</script>

</head>