Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: Source/core/rendering/RenderLayer.cpp

Issue 191693002: Delay scrollContents until the next paint (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix nit Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | Source/core/rendering/RenderView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 476 matching lines...) Expand 10 before | Expand all | Expand 10 after
487 if (subtreeIsInvisible()) 487 if (subtreeIsInvisible())
488 return; 488 return;
489 489
490 bool positionChanged = updateLayerPosition(); 490 bool positionChanged = updateLayerPosition();
491 if (positionChanged) 491 if (positionChanged)
492 flags |= HasChangedAncestor; 492 flags |= HasChangedAncestor;
493 493
494 if (geometryMap) 494 if (geometryMap)
495 geometryMap->pushMappingsToAncestor(this, parent()); 495 geometryMap->pushMappingsToAncestor(this, parent());
496 496
497 if (flags & HasChangedAncestor || flags & HasSeenViewportConstrainedAncestor || flags & IsOverflowScroll) 497 if ((flags & HasChangedAncestor) || (flags & HasSeenViewportConstrainedAnces tor) || (flags & IsOverflowScroll))
498 m_clipper.clearClipRects(); 498 m_clipper.clearClipRects();
499 499
500 if (renderer()->style()->hasViewportConstrainedPosition()) 500 if (renderer()->style()->hasViewportConstrainedPosition())
501 flags |= HasSeenViewportConstrainedAncestor; 501 flags |= HasSeenViewportConstrainedAncestor;
502 502
503 if (renderer()->hasOverflowClip()) 503 if (renderer()->hasOverflowClip())
504 flags |= HasSeenAncestorWithOverflowClip; 504 flags |= HasSeenAncestorWithOverflowClip;
505 505
506 if (flags & HasSeenViewportConstrainedAncestor 506 if ((flags & IsOverflowScroll) && (flags & HasSeenAncestorWithOverflowClip) && !m_canSkipRepaintRectsUpdateOnScroll) {
507 || (flags & IsOverflowScroll && flags & HasSeenAncestorWithOverflowClip && !m_canSkipRepaintRectsUpdateOnScroll)) {
508 // FIXME: This may not be needed. Once repaint-after-layout isn't 507 // FIXME: This may not be needed. Once repaint-after-layout isn't
509 // under-painting for layer's we should see if this can be removed. 508 // under-painting for layer's we should see if this can be removed.
510 LayoutRectRecorder recorder(*m_renderer); 509 LayoutRectRecorder recorder(*m_renderer);
511
512 // FIXME: Remove incremental compositing updates after fixing the chicke n/egg issues
513 // https://code.google.com/p/chromium/issues/detail?id=343756
514 DisableCompositingQueryAsserts disabler;
515 // FIXME: We could track the repaint container as we walk down the tree. 510 // FIXME: We could track the repaint container as we walk down the tree.
516 repainter().computeRepaintRects(renderer()->containerForRepaint(), geome tryMap); 511 repainter().computeRepaintRects(renderer()->containerForRepaint(), geome tryMap);
517 } else { 512 } else {
518 // Check that RenderLayerRepainter's cached rects are correct. 513 // Check that RenderLayerRepainter's cached rects are correct.
519 // FIXME: re-enable these assertions when the issue with table cells is resolved: https://bugs.webkit.org/show_bug.cgi?id=103432 514 // FIXME: re-enable these assertions when the issue with table cells is resolved: https://bugs.webkit.org/show_bug.cgi?id=103432
520 // ASSERT(repainter().m_repaintRect == renderer()->clippedOverflowRectFo rRepaint(renderer()->containerForRepaint())); 515 // ASSERT(repainter().m_repaintRect == renderer()->clippedOverflowRectFo rRepaint(renderer()->containerForRepaint()));
521 // ASSERT(repainter().m_outlineBox == renderer()->outlineBoundsForRepain t(renderer()->containerForRepaint(), geometryMap)); 516 // ASSERT(repainter().m_outlineBox == renderer()->outlineBoundsForRepain t(renderer()->containerForRepaint(), geometryMap));
522 } 517 }
523 518
524 for (RenderLayer* child = firstChild(); child; child = child->nextSibling()) 519 for (RenderLayer* child = firstChild(); child; child = child->nextSibling())
(...skipping 3655 matching lines...) Expand 10 before | Expand all | Expand 10 after
4180 } 4175 }
4181 } 4176 }
4182 4177
4183 void showLayerTree(const WebCore::RenderObject* renderer) 4178 void showLayerTree(const WebCore::RenderObject* renderer)
4184 { 4179 {
4185 if (!renderer) 4180 if (!renderer)
4186 return; 4181 return;
4187 showLayerTree(renderer->enclosingLayer()); 4182 showLayerTree(renderer->enclosingLayer());
4188 } 4183 }
4189 #endif 4184 #endif
OLDNEW
« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | Source/core/rendering/RenderView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698