Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Side by Side Diff: Source/core/rendering/RenderLayer.cpp

Issue 191693002: Delay scrollContents until the next paint (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fixed typos Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 469 matching lines...) Expand 10 before | Expand all | Expand 10 after
480 if (subtreeIsInvisible()) 480 if (subtreeIsInvisible())
481 return; 481 return;
482 482
483 bool positionChanged = updateLayerPosition(); 483 bool positionChanged = updateLayerPosition();
484 if (positionChanged) 484 if (positionChanged)
485 flags |= HasChangedAncestor; 485 flags |= HasChangedAncestor;
486 486
487 if (geometryMap) 487 if (geometryMap)
488 geometryMap->pushMappingsToAncestor(this, parent()); 488 geometryMap->pushMappingsToAncestor(this, parent());
489 489
490 if (flags & HasChangedAncestor || flags & HasSeenViewportConstrainedAncestor || flags & IsOverflowScroll) 490 if ((flags & HasChangedAncestor) || (flags & HasSeenViewportConstrainedAnces tor) || (flags & IsOverflowScroll))
491 m_clipper.clearClipRects(); 491 m_clipper.clearClipRects();
492 492
493 if (renderer()->style()->hasViewportConstrainedPosition()) 493 if (renderer()->style()->hasViewportConstrainedPosition())
494 flags |= HasSeenViewportConstrainedAncestor; 494 flags |= HasSeenViewportConstrainedAncestor;
495 495
496 if (renderer()->hasOverflowClip()) 496 if (renderer()->hasOverflowClip())
497 flags |= HasSeenAncestorWithOverflowClip; 497 flags |= HasSeenAncestorWithOverflowClip;
498 498
499 if (flags & HasSeenViewportConstrainedAncestor 499 if ((flags & IsOverflowScroll) && (flags & HasSeenAncestorWithOverflowClip) && !m_canSkipRepaintRectsUpdateOnScroll) {
500 || (flags & IsOverflowScroll && flags & HasSeenAncestorWithOverflowClip && !m_canSkipRepaintRectsUpdateOnScroll)) {
501 // FIXME: Remove incremental compositing updates after fixing the chicke n/egg issues
502 // https://code.google.com/p/chromium/issues/detail?id=343756
503 DisableCompositingQueryAsserts disabler;
504 // FIXME: We could track the repaint container as we walk down the tree. 500 // FIXME: We could track the repaint container as we walk down the tree.
505 repainter().computeRepaintRects(renderer()->containerForRepaint(), geome tryMap); 501 repainter().computeRepaintRects(renderer()->containerForRepaint(), geome tryMap);
506 } else { 502 } else {
507 // Check that RenderLayerRepainter's cached rects are correct. 503 // Check that RenderLayerRepainter's cached rects are correct.
508 // FIXME: re-enable these assertions when the issue with table cells is resolved: https://bugs.webkit.org/show_bug.cgi?id=103432 504 // FIXME: re-enable these assertions when the issue with table cells is resolved: https://bugs.webkit.org/show_bug.cgi?id=103432
509 // ASSERT(repainter().m_repaintRect == renderer()->clippedOverflowRectFo rRepaint(renderer()->containerForRepaint())); 505 // ASSERT(repainter().m_repaintRect == renderer()->clippedOverflowRectFo rRepaint(renderer()->containerForRepaint()));
510 // ASSERT(repainter().m_outlineBox == renderer()->outlineBoundsForRepain t(renderer()->containerForRepaint(), geometryMap)); 506 // ASSERT(repainter().m_outlineBox == renderer()->outlineBoundsForRepain t(renderer()->containerForRepaint(), geometryMap));
511 } 507 }
512 508
513 for (RenderLayer* child = firstChild(); child; child = child->nextSibling()) 509 for (RenderLayer* child = firstChild(); child; child = child->nextSibling())
(...skipping 3549 matching lines...) Expand 10 before | Expand all | Expand 10 after
4063 } 4059 }
4064 } 4060 }
4065 4061
4066 void showLayerTree(const WebCore::RenderObject* renderer) 4062 void showLayerTree(const WebCore::RenderObject* renderer)
4067 { 4063 {
4068 if (!renderer) 4064 if (!renderer)
4069 return; 4065 return;
4070 showLayerTree(renderer->enclosingLayer()); 4066 showLayerTree(renderer->enclosingLayer());
4071 } 4067 }
4072 #endif 4068 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698