Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: gpu/command_buffer/client/gles2_implementation.cc

Issue 1916923004: Request context sharing via content::ContextProviderCommandBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sharegroup: . Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/client/gles2_implementation.cc
diff --git a/gpu/command_buffer/client/gles2_implementation.cc b/gpu/command_buffer/client/gles2_implementation.cc
index 49835b833cf7bab2a10b4bb9907c5643dec4d0b3..b0a0a848f6090c48b9a7d0633aa4592367b53d8f 100644
--- a/gpu/command_buffer/client/gles2_implementation.cc
+++ b/gpu/command_buffer/client/gles2_implementation.cc
@@ -111,7 +111,7 @@ GLES2Implementation::SingleThreadChecker::~SingleThreadChecker() {
GLES2Implementation::GLES2Implementation(
GLES2CmdHelper* helper,
- ShareGroup* share_group,
+ scoped_refptr<ShareGroup> share_group,
TransferBufferInterface* transfer_buffer,
bool bind_generates_resource,
bool lose_context_when_out_of_memory,
@@ -186,6 +186,7 @@ GLES2Implementation::GLES2Implementation(
bind_generates_resource,
gpu_control_->GetCommandBufferID().GetUnsafeValue()));
DCHECK(share_group_->bind_generates_resource() == bind_generates_resource);
+ DCHECK(!share_group_->IsLost());
piman 2016/04/27 22:09:33 I don't think we want this DCHECK - another thread
danakj 2016/04/28 00:25:58 Ah.. ya fair point. Removed and moved the check to
memset(&reserved_ids_, 0, sizeof(reserved_ids_));
}

Powered by Google App Engine
This is Rietveld 408576698