Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1916883003:
Default icon should use the image skia created by ResourceBundle (Closed)
DescriptionDefault icon should use the image skia created by ResourceBundle
Current code gets 2x image first then shrink to 1x. It should simply use the image skia created by ResourceBundle.
BUG=605884
Committed: https://crrev.com/50ed8e6dddc43144f9aad3d08aab379e19df97a3
Cr-Commit-Position: refs/heads/master@{#390590}
Patch Set 1 : #
Messages
Total messages: 28 (17 generated)
Patchset #3 (id:40001) has been deleted
Patchset #1 (id:1) has been deleted
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916883003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916883003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix AppInfo icon BUG= ========== to ========== Fix AppInfo icon BUG=605884 ==========
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916883003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916883003/60001
Description was changed from ========== Fix AppInfo icon BUG=605884 ========== to ========== Default icon should use the image skia created by ResourceBundle Existing code gets 2x image first then shrink to 1x. It should simply use the image skia created by ResourceBundle. BUG=605884 ==========
oshima@chromium.org changed reviewers: + sashab@chromium.org
Patchset #1 (id:20001) has been deleted
Description was changed from ========== Default icon should use the image skia created by ResourceBundle Existing code gets 2x image first then shrink to 1x. It should simply use the image skia created by ResourceBundle. BUG=605884 ========== to ========== Default icon should use the image skia created by ResourceBundle Current code gets 2x image first then shrink to 1x. It should simply use the image skia created by ResourceBundle. BUG=605884 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ping?
oshima@chromium.org changed reviewers: + benwells@chromium.org - sashab@chromium.org
-> benwells (just noticed crrev.com/1925533005)
lgtm
The CQ bit was checked by oshima@chromium.org
The CQ bit was unchecked by oshima@chromium.org
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916883003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916883003/60001
Message was sent while issue was closed.
Description was changed from ========== Default icon should use the image skia created by ResourceBundle Current code gets 2x image first then shrink to 1x. It should simply use the image skia created by ResourceBundle. BUG=605884 ========== to ========== Default icon should use the image skia created by ResourceBundle Current code gets 2x image first then shrink to 1x. It should simply use the image skia created by ResourceBundle. BUG=605884 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:60001)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/50ed8e6dddc43144f9aad3d08aab379e19df97a3 Cr-Commit-Position: refs/heads/master@{#390590}
Message was sent while issue was closed.
Description was changed from ========== Default icon should use the image skia created by ResourceBundle Current code gets 2x image first then shrink to 1x. It should simply use the image skia created by ResourceBundle. BUG=605884 ========== to ========== Default icon should use the image skia created by ResourceBundle Current code gets 2x image first then shrink to 1x. It should simply use the image skia created by ResourceBundle. BUG=605884 Committed: https://crrev.com/50ed8e6dddc43144f9aad3d08aab379e19df97a3 Cr-Commit-Position: refs/heads/master@{#390590} ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
