Delete the |complete_type_set| field from mojom_types.mojom

Delete the |complete_type_set| field from mojom_types.mojom

The |complete_type_set| field was deprecated and not being populated.
We also delete the code used to populate this field: The functions FindReachableTypes() in user_defined_types.go and ReferencedUserDefinedTypes() from the TypeRef interface in types.go.

We also delete the struct ServiceTypeInfo since it would now contain only a single string field and we replace
map<string, ServiceTypeInfo> services_by_name with map<string, string> services, moving the string field
from ServiceTypeInfo directly into the value of the map.

This work is in preparation for adding new code to analyze the type graph for the purpose of finding cycles. The code we are deleting also analyzed the type graph but in a different way. Since the older way of analyzing the type graph is now obsolete, it will reduce confusion to remove it before adding a newer way to analyze the type graph.

bug=#694

R=azani@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/fe410c603bb479878b793b49140032045219e1e4

[rudominer, 2016-04-25 22:28:12]

Description was changed from

==========
Delete the |complete_type_set| field from mojom_types.mojom
==========

to

==========
Delete the |complete_type_set| field from mojom_types.mojom

The |complete_type_set| field was deprecated and not being populated.
We also delete the code used to populate this field: The functions
FindReachableTypes() in user_defined_types.go and ReferencedUserDefinedTypes()
from the TypeRef interface in types.go.

This work is in preparation for adding new code to analyze the type graph for
the purposes of finding cycles. The code we are deleting also analyzed the type
graph but in a different way. Since the older way of anlayzing the type graph is
now obsolete, it will reduce confusion to remove it before adding a newer way to
analyze the type graph.

bug=#694
==========

[rudominer, 2016-04-25 22:29:10]

Description was changed from

==========
Delete the |complete_type_set| field from mojom_types.mojom

The |complete_type_set| field was deprecated and not being populated.
We also delete the code used to populate this field: The functions
FindReachableTypes() in user_defined_types.go and ReferencedUserDefinedTypes()
from the TypeRef interface in types.go.

This work is in preparation for adding new code to analyze the type graph for
the purposes of finding cycles. The code we are deleting also analyzed the type
graph but in a different way. Since the older way of anlayzing the type graph is
now obsolete, it will reduce confusion to remove it before adding a newer way to
analyze the type graph.

bug=#694
==========

to

==========
Delete the |complete_type_set| field from mojom_types.mojom

The |complete_type_set| field was deprecated and not being populated.
We also delete the code used to populate this field: The functions
FindReachableTypes() in user_defined_types.go and ReferencedUserDefinedTypes()
from the TypeRef interface in types.go.

This work is in preparation for adding new code to analyze the type graph for
the purpose of finding cycles. The code we are deleting also analyzed the type
graph but in a different way. Since the older way of analyzing the type graph is
now obsolete, it will reduce confusion to remove it before adding a newer way to
analyze the type graph.

bug=#694
==========

[rudominer, 2016-04-25 23:11:53]

Patchset #1 (id:1) has been deleted

[rudominer, 2016-04-25 23:30:10]

Description was changed from

==========
Delete the |complete_type_set| field from mojom_types.mojom

The |complete_type_set| field was deprecated and not being populated.
We also delete the code used to populate this field: The functions
FindReachableTypes() in user_defined_types.go and ReferencedUserDefinedTypes()
from the TypeRef interface in types.go.

This work is in preparation for adding new code to analyze the type graph for
the purpose of finding cycles. The code we are deleting also analyzed the type
graph but in a different way. Since the older way of analyzing the type graph is
now obsolete, it will reduce confusion to remove it before adding a newer way to
analyze the type graph.

bug=#694
==========

to

==========
Delete the |complete_type_set| field from mojom_types.mojom

The |complete_type_set| field was deprecated and not being populated.
We also delete the code used to populate this field: The functions
FindReachableTypes() in user_defined_types.go and ReferencedUserDefinedTypes()
from the TypeRef interface in types.go.

We also delete the struct ServiceTypeInfo since it would now contain only a
single string field and we replace
map<string, ServiceTypeInfo> services_by_name with map<string, string> services,
moving the string field
from ServiceTypeInfo directly into the value of the map.

This work is in preparation for adding new code to analyze the type graph for
the purpose of finding cycles. The code we are deleting also analyzed the type
graph but in a different way. Since the older way of analyzing the type graph is
now obsolete, it will reduce confusion to remove it before adding a newer way to
analyze the type graph.

bug=#694
==========

[rudominer, 2016-04-25 23:30:27]

rudominer@chromium.org changed reviewers:
+ azani@chromium.org

[rudominer, 2016-04-25 23:30:28]

Hi Alex, ptal.

[azani, 2016-04-26 00:13:05]

lgtm

[rudominer, 2016-04-26 00:18:09]

Description was changed from

==========
Delete the |complete_type_set| field from mojom_types.mojom

The |complete_type_set| field was deprecated and not being populated.
We also delete the code used to populate this field: The functions
FindReachableTypes() in user_defined_types.go and ReferencedUserDefinedTypes()
from the TypeRef interface in types.go.

We also delete the struct ServiceTypeInfo since it would now contain only a
single string field and we replace
map<string, ServiceTypeInfo> services_by_name with map<string, string> services,
moving the string field
from ServiceTypeInfo directly into the value of the map.

This work is in preparation for adding new code to analyze the type graph for
the purpose of finding cycles. The code we are deleting also analyzed the type
graph but in a different way. Since the older way of analyzing the type graph is
now obsolete, it will reduce confusion to remove it before adding a newer way to
analyze the type graph.

bug=#694
==========

to

==========
Delete the |complete_type_set| field from mojom_types.mojom

The |complete_type_set| field was deprecated and not being populated.
We also delete the code used to populate this field: The functions
FindReachableTypes() in user_defined_types.go and ReferencedUserDefinedTypes()
from the TypeRef interface in types.go.

We also delete the struct ServiceTypeInfo since it would now contain only a
single string field and we replace
map<string, ServiceTypeInfo> services_by_name with map<string, string> services,
moving the string field
from ServiceTypeInfo directly into the value of the map.

This work is in preparation for adding new code to analyze the type graph for
the purpose of finding cycles. The code we are deleting also analyzed the type
graph but in a different way. Since the older way of analyzing the type graph is
now obsolete, it will reduce confusion to remove it before adding a newer way to
analyze the type graph.

bug=#694

R=azani@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/fe410c603bb479878b793b49140...
==========

[rudominer, 2016-04-26 00:18:11]

Committed patchset #1 (id:20001) manually as
fe410c603bb479878b793b49140032045219e1e4 (presubmit successful).