dart2js: Avoid empty else clauses in generators.

dart2js: Avoid empty else clauses in generators.

R=sigurdm@google.com

Committed: https://github.com/dart-lang/sdk/commit/a02c5798a4b9c682cfe5fddbf48f053c9c677b68

Reverted: https://github.com/dart-lang/sdk/commit/803826256d0be2c3560705c084d20ed78d1fca74
Committed: https://github.com/dart-lang/sdk/commit/94df5a0c24b07ac24a7eebfc4194c01df8249c5f

[sra1, 2016-04-25 17:32:09]

sra@google.com changed reviewers:
+ sigurdm@google.com

[sigurdm, 2016-04-26 05:15:05]

LGTM with comments

https://codereview.chromium.org/1916863002/diff/1/pkg/compiler/lib/src/js/rew...
File pkg/compiler/lib/src/js/rewrite_async.dart (right):

https://codereview.chromium.org/1916863002/diff/1/pkg/compiler/lib/src/js/rew...
pkg/compiler/lib/src/js/rewrite_async.dart:1: tra// Copyright (c) 2015, the Dart
project authors.  Please see the AUTHORS file
This looks like a mistake

https://codereview.chromium.org/1916863002/diff/1/pkg/compiler/lib/src/js/rew...
pkg/compiler/lib/src/js/rewrite_async.dart:1067: js.Block
translateToStatement(js.Statement node) {
I think the return type should be `js.Statement` now.

https://codereview.chromium.org/1916863002/diff/1/pkg/compiler/lib/src/js/rew...
pkg/compiler/lib/src/js/rewrite_async.dart:1075: return resultBuffer.single;
For the case where `node` is an empty block (can that even happen?), Should you
not also do
```
if (resultBuffer.isEmpty) {
  return new EmptyStatement;
}
```
?

https://codereview.chromium.org/1916863002/diff/1/pkg/compiler/lib/src/js/rew...
pkg/compiler/lib/src/js/rewrite_async.dart:1075: return resultBuffer.single;
Either put the return on the same  line as the if, or surround it with braces.

https://codereview.chromium.org/1916863002/diff/1/pkg/compiler/lib/src/js/rew...
pkg/compiler/lib/src/js/rewrite_async.dart:1432: js.Block body =
translateToStatement(node.body);
This would also become a `js.Statement`

[sra1, 2016-07-26 01:43:26]

Description was changed from

==========
dart2js: Avoid empty else clauses in generators.
==========

to

==========
dart2js: Avoid empty else clauses in generators.

R=sigurdm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a02c5798a4b9c682cfe5fddbf48f053c9c677b68
==========

[sra1, 2016-07-26 01:43:27]

Committed patchset #3 (id:40001) manually as
a02c5798a4b9c682cfe5fddbf48f053c9c677b68 (presubmit successful).

[sra1, 2016-07-26 01:55:17]

Description was changed from

==========
dart2js: Avoid empty else clauses in generators.

R=sigurdm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a02c5798a4b9c682cfe5fddbf48f053c9c677b68
==========

to

==========
dart2js: Avoid empty else clauses in generators.

R=sigurdm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a02c5798a4b9c682cfe5fddbf48f053c9c677b68

Reverted:
https://github.com/dart-lang/sdk/commit/803826256d0be2c3560705c084d20ed78d1fca74
==========

[sra1, 2016-07-26 16:58:45]

Description was changed from

==========
dart2js: Avoid empty else clauses in generators.

R=sigurdm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a02c5798a4b9c682cfe5fddbf48f053c9c677b68

Reverted:
https://github.com/dart-lang/sdk/commit/803826256d0be2c3560705c084d20ed78d1fca74
==========

to

==========
dart2js: Avoid empty else clauses in generators.

R=sigurdm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a02c5798a4b9c682cfe5fddbf48f053c9c677b68

Reverted:
https://github.com/dart-lang/sdk/commit/803826256d0be2c3560705c084d20ed78d1fca74
Committed:
https://github.com/dart-lang/sdk/commit/94df5a0c24b07ac24a7eebfc4194c01df8249c5f
==========

[sra1, 2016-07-26 16:58:47]

Committed patchset #5 (id:80001) manually as
94df5a0c24b07ac24a7eebfc4194c01df8249c5f (presubmit successful).