Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1916853002: Pass around shorthand info instead of storing it (Closed)

Created:
4 years, 8 months ago by rwlbuis
Modified:
4 years, 8 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-css, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, blink-reviews, blink-reviews-layout_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass around shorthand info instead of storing it Pass around shorthand info instead of storing it, since at the callsites of addProperty/parseSingleValue we know what shorthand we are dealing with. Committed: https://crrev.com/25a6cf5992854d9dcc6a9222c94f10841d5b27e0 Cr-Commit-Position: refs/heads/master@{#389708}

Patch Set 1 #

Patch Set 2 : V2 #

Patch Set 3 : V3 #

Patch Set 4 : V4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -158 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 2 3 chunks +4 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 43 chunks +121 lines, -131 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
rwlbuis
PTAL. Not sure if this needs a bug.
4 years, 8 months ago (2016-04-25 23:17:44 UTC) #5
Timothy Loh
On 2016/04/25 23:17:44, rwlbuis wrote: > PTAL. Not sure if this needs a bug. lgtm
4 years, 8 months ago (2016-04-26 03:13:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916853002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916853002/80001
4 years, 8 months ago (2016-04-26 04:55:01 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 8 months ago (2016-04-26 06:40:08 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 06:41:11 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/25a6cf5992854d9dcc6a9222c94f10841d5b27e0
Cr-Commit-Position: refs/heads/master@{#389708}

Powered by Google App Engine
This is Rietveld 408576698