Ensure Origin Thread Affinity for BlameContext

base/trace_event/blame_context_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/trace_event/blame_context.h"
 
 #include "base/json/json_writer.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted_memory.h"
 #include "base/run_loop.h"
@@ skipping 23 matching lines @@
                      nullptr) {}
 
   TestBlameContext(int id, const TestBlameContext& parent)
       : BlameContext(kTestBlameContextCategory,
                      kTestBlameContextName,
                      kTestBlameContextType,
                      kTestBlameContextScope,
                      id,
                      &parent) {}
 
+  ~TestBlameContext() override { UnregisterFromTraceLog(); }
+
  protected:
   void AsValueInto(trace_event::TracedValue* state) override {
     BlameContext::AsValueInto(state);
     state->SetBoolean("crossStreams", false);
   }
 };
 
 class DisabledTestBlameContext : public BlameContext {
  public:
   explicit DisabledTestBlameContext(int id)
       : BlameContext(kDisabledTestBlameContextCategory,
                      kTestBlameContextName,
                      kTestBlameContextType,
                      kTestBlameContextScope,
                      id,
                      nullptr) {}
+
+  ~DisabledTestBlameContext() override { UnregisterFromTraceLog(); }
 };
 
 void OnTraceDataCollected(Closure quit_closure,
                           trace_event::TraceResultBuffer* buffer,
                           const scoped_refptr<RefCountedString>& json,
                           bool has_more_events) {
   buffer->AddFragment(json->data());
   if (!has_more_events)
     quit_closure.Run();
 }
 
 class BlameContextTest : public testing::Test {
  public:
   void StartTracing();
   void StopTracing();
   std::unique_ptr<trace_analyzer::TraceAnalyzer> CreateTraceAnalyzer();
+ protected:
+  MessageLoop loop_;
 };
 
 void BlameContextTest::StartTracing() {
   trace_event::TraceLog::GetInstance()->SetEnabled(
       trace_event::TraceConfig("*"), trace_event::TraceLog::RECORDING_MODE);
 }
 
 void BlameContextTest::StopTracing() {
   trace_event::TraceLog::GetInstance()->SetDisabled();
 }
@@ skipping 122 matching lines @@
               "\"id_ref\":\"0x5678\","
               "\"scope\":\"TestBlameContextScope\""
           "}"
       "}";
 
   std::string snapshot_json;
   JSONWriter::Write(*events[2]->GetKnownArgAsValue("snapshot"), &snapshot_json);
   EXPECT_EQ(kExpectedSnapshotJson, snapshot_json);
 }
 
+class TestBlameContextWithSleep : public BlameContext {
+ public:
+  TestBlameContextWithSleep()
+      : BlameContext(kTestBlameContextCategory,
+                     kTestBlameContextName,
+                     kTestBlameContextType,
+                     kTestBlameContextScope,
+                     0,
+                     nullptr),
+        callback_running_(false) {}
+
+  ~TestBlameContextWithSleep() override {
+    UnregisterFromTraceLog();
+    CHECK(!callback_running_);
+  }
+
+  void OnTraceLogEnabled() override {
+    callback_running_ = true;
+
+    // Sleep for longer time than the Sleep() in RaceWithDTOR.
+    PlatformThread::Sleep(TimeDelta::FromMilliseconds(200));
+
+    // Now the instance is already deleted, so it would crash inside.
+    BlameContext::OnTraceLogEnabled();
+    callback_running_ = false;
+  }
+
+ private:
+  bool callback_running_;
+};
+
+TEST_F(BlameContextTest, RaceWithDTOR) {
+  Thread thread("test thread");
+  CHECK(thread.Start());
+  CHECK(thread.message_loop());
+
+  std::unique_ptr<TestBlameContextWithSleep> derived;
+  derived.reset(new TestBlameContextWithSleep());
+  derived->Initialize();
+  thread.task_runner()->PostTask(
+      FROM_HERE,
+      base::Bind(&BlameContextTest::StartTracing, base::Unretained(this)));
+  PlatformThread::Sleep(TimeDelta::FromMilliseconds(100));
+  derived.reset();
+}
+
 }  // namepace
 }  // namespace trace_event
 }  // namespace base