Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 1916833002: [compiler] Prevent unnecessary regeneration of baseline code. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Prevent unnecessary regeneration of baseline code. This avoids regenerating baseline code for a closure when such code already exists for the shared function info. This is also important because the baseline code might contain deoptimization support. R=rmcilroy@chromium.org BUG=chromium:606376 LOG=n Committed: https://crrev.com/f38932c794b46cd91e2e37c15bbd7bc8db873172 Cr-Commit-Position: refs/heads/master@{#35785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/compiler.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-25 16:41:48 UTC) #1
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-26 08:14:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916833002/1
4 years, 8 months ago (2016-04-26 08:50:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 08:53:00 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 08:53:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f38932c794b46cd91e2e37c15bbd7bc8db873172
Cr-Commit-Position: refs/heads/master@{#35785}

Powered by Google App Engine
This is Rietveld 408576698