Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 1916803002: PPC: [Interpreter] Use FastNewSloppyArguments when possible. (Closed)

Created:
4 years, 8 months ago by JaideepBajwa
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [Interpreter] Use FastNewSloppyArguments when possible. Port c005029aa47f6e27d50e92a70f526f1651b18553 Original commit message: Use the FastNewSloppyArgumentsStub in the interpreter when function doesn't have duplicate parameters. R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4280 LOG=N Committed: https://crrev.com/431ea9a0aa1bebe035c9b4dee024542751e1cfac Cr-Commit-Position: refs/heads/master@{#35772}

Patch Set 1 #

Total comments: 1

Patch Set 2 : added missing comments #

Patch Set 3 : fixed register name in comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M src/ppc/code-stubs-ppc.cc View 1 2 2 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
JaideepBajwa
PTAL
4 years, 8 months ago (2016-04-25 15:39:42 UTC) #1
MTBrandyberry
LGTM assuming the comment is addressed. https://codereview.chromium.org/1916803002/diff/1/src/ppc/code-stubs-ppc.cc File src/ppc/code-stubs-ppc.cc (right): https://codereview.chromium.org/1916803002/diff/1/src/ppc/code-stubs-ppc.cc#newcode4941 src/ppc/code-stubs-ppc.cc:4941: Copy over the ...
4 years, 8 months ago (2016-04-25 15:46:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916803002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916803002/40001
4 years, 8 months ago (2016-04-25 16:10:39 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-25 16:44:51 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 16:45:38 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/431ea9a0aa1bebe035c9b4dee024542751e1cfac
Cr-Commit-Position: refs/heads/master@{#35772}

Powered by Google App Engine
This is Rietveld 408576698