- Allow for loading dart:html and friends into the standalone

- Allow for loading dart:html and friends into the standalone
  dart_bootstrap binary to evaluate startup and compilation
  performance.

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/3884fd4e4b6d94e9b88fa8ef926b47f5e71e8c27

[siva, 2016-04-25 23:38:30]

asiva@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-04-25 23:38:31]

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/bin.gypi#ne...
runtime/bin/bin.gypi:922: '<(html_cc_file)',
Why do we need this here?

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/bin.gypi#ne...
runtime/bin/bin.gypi:1327: '<(html_cc_file)',
Ditto ?

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/builtin.cc
File runtime/bin/builtin.cc (right):

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/builtin.cc#...
runtime/bin/builtin.cc:21: { DartUtils::kHTMLLibURL, html_source_paths_, NULL,
NULL, true },
Do is dart:html treated differently here with a define?

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/dartutils.cc
File runtime/bin/dartutils.cc (right):

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/dartutils.c...
runtime/bin/dartutils.cc:44: const char* const DartUtils::kHTMLLibURL =
"dart:html";
Ditto.

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/dartutils.c...
runtime/bin/dartutils.cc:403: // If this is a Dart Scheme URL or 'part' of a io
library
Comment needs to change from io library to  'part' of any dart scheme library

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/dartutils.c...
runtime/bin/dartutils.cc:420: }
This FindId part can be hoisted out of the if (...) { .... } else { ... }

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/dartutils.c...
runtime/bin/dartutils.cc:446: }
This is not needed right?

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/dartutils.h
File runtime/bin/dartutils.h (right):

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/dartutils.h...
runtime/bin/dartutils.h:226: static const char* const kHTMLLibURL;
Is this needed?

https://codereview.chromium.org/1916793003/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1916793003/diff/20001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:2926: return CloseBlock();
This code has been moved from somewhere?

[Ivan Posva, 2016-04-26 21:17:43]

Thanks!

-Ivan

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/bin.gypi#ne...
runtime/bin/bin.gypi:922: '<(html_cc_file)',
On 2016/04/25 23:38:31, siva wrote:
> Why do we need this here?

Left over from development. Thanks for spotting this...

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/bin.gypi#ne...
runtime/bin/bin.gypi:1327: '<(html_cc_file)',
On 2016/04/25 23:38:31, siva wrote:
> Ditto ?

Done.

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/builtin.cc
File runtime/bin/builtin.cc (right):

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/builtin.cc#...
runtime/bin/builtin.cc:21: { DartUtils::kHTMLLibURL, html_source_paths_, NULL,
NULL, true },
On 2016/04/25 23:38:31, siva wrote:
> Do is dart:html treated differently here with a define?

It does not need to be.

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/dartutils.cc
File runtime/bin/dartutils.cc (right):

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/dartutils.c...
runtime/bin/dartutils.cc:44: const char* const DartUtils::kHTMLLibURL =
"dart:html";
On 2016/04/25 23:38:31, siva wrote:
> Ditto.

Done.

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/dartutils.c...
runtime/bin/dartutils.cc:403: // If this is a Dart Scheme URL or 'part' of a io
library
On 2016/04/25 23:38:31, siva wrote:
> Comment needs to change from io library to  'part' of any dart scheme library

Done.

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/dartutils.c...
runtime/bin/dartutils.cc:446: }
On 2016/04/25 23:38:31, siva wrote:
> This is not needed right?

Refactored this code here and above...

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/dartutils.h
File runtime/bin/dartutils.h (right):

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/dartutils.h...
runtime/bin/dartutils.h:226: static const char* const kHTMLLibURL;
On 2016/04/25 23:38:31, siva wrote:
> Is this needed?

No.

https://codereview.chromium.org/1916793003/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1916793003/diff/20001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:2926: return CloseBlock();
On 2016/04/25 23:38:31, siva wrote:
> This code has been moved from somewhere?

From line 2951. Will be removed there once I am convinced this is the right
thing to do.

https://codereview.chromium.org/1916793003/diff/20001/sdk/lib/html/html_commo...
File sdk/lib/html/html_common/html_common.dart (right):

https://codereview.chromium.org/1916793003/diff/20001/sdk/lib/html/html_commo...
sdk/lib/html/html_common/html_common.dart:26: part 'standalone_additions.dart';
I will be moving this into a patch file so that we do not need to change shared
code.

[Ivan Posva, 2016-05-03 21:46:40]

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/dartutils.cc
File runtime/bin/dartutils.cc (right):

https://codereview.chromium.org/1916793003/diff/20001/runtime/bin/dartutils.c...
runtime/bin/dartutils.cc:420: }
On 2016/04/25 23:38:31, siva wrote:
> This FindId part can be hoisted out of the if (...) { .... } else { ... }

Unfortunately not as for one case you are looking for the url_string, while in
the other the library_url_string.

https://codereview.chromium.org/1916793003/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1916793003/diff/20001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:2926: return CloseBlock();
On 2016/04/26 21:17:43, Ivan Posva wrote:
> On 2016/04/25 23:38:31, siva wrote:
> > This code has been moved from somewhere?
> 
> From line 2951. Will be removed there once I am convinced this is the right
> thing to do.

Removed for now again.

https://codereview.chromium.org/1916793003/diff/20001/sdk/lib/html/html_commo...
File sdk/lib/html/html_common/html_common.dart (right):

https://codereview.chromium.org/1916793003/diff/20001/sdk/lib/html/html_commo...
sdk/lib/html/html_common/html_common.dart:26: part 'standalone_additions.dart';
On 2016/04/26 21:17:43, Ivan Posva wrote:
> I will be moving this into a patch file so that we do not need to change
shared
> code.

Done.

[siva, 2016-05-03 23:32:47]

lgtm

[Ivan Posva, 2016-05-04 03:33:19]

Description was changed from

==========
- Allow for loading dart:html and friends into the standalone
  dart_bootstrap binary to evaluate startup and compilation
  performance.

BUG=
==========

to

==========
- Allow for loading dart:html and friends into the standalone
  dart_bootstrap binary to evaluate startup and compilation
  performance.

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3884fd4e4b6d94e9b88fa8ef926b47f5e71e8c27
==========

[Ivan Posva, 2016-05-04 03:33:21]

Committed patchset #4 (id:60001) manually as
3884fd4e4b6d94e9b88fa8ef926b47f5e71e8c27 (presubmit successful).