Use BUILD_TYPE in cmake_build

Use BUILD_TYPE in cmake_build.

Build files were directly written to the out directory. This change makes them go to the expected out/{Release, Debug} directory.


BUG=skia:5160
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1916773002
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed: https://skia.googlesource.com/skia/+/5d36360c47ed48c93e6928cc5de1a5ebd65b6eea

[rmistry, 2016-04-25 12:08:05]

Description was changed from

==========
Use BUILD_TYPE in cmake

BUG=skia:
==========

to

==========
Use BUILD_TYPE in cmake

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

[rmistry, 2016-04-25 12:14:06]

Description was changed from

==========
Use BUILD_TYPE in cmake

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

to

==========
Use BUILD_TYPE in cmake_build

BUG=skia:5160

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

[rmistry, 2016-04-25 12:16:26]

Description was changed from

==========
Use BUILD_TYPE in cmake_build

BUG=skia:5160

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

to

==========
Use BUILD_TYPE in cmake_build.

Build files were directly written to the out directory. This change makes them
go to the expected out/{Release, Debug} directory.


BUG=skia:5160

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

[rmistry, 2016-04-25 12:16:42]

rmistry@google.com changed reviewers:
+ borenet@google.com

[borenet, 2016-04-25 12:30:50]

LGTM with question

https://codereview.chromium.org/1916773002/diff/20001/cmake/cmake_build
File cmake/cmake_build (right):

https://codereview.chromium.org/1916773002/diff/20001/cmake/cmake_build#newco...
cmake/cmake_build:30: pushd $SKIA_OUT/$BUILDTYPE
Note: most bots write to out/$BUILDERNAME/$BUILDTYPE.  Is that necessary here?

[rmistry, 2016-04-25 12:34:25]

https://codereview.chromium.org/1916773002/diff/20001/cmake/cmake_build
File cmake/cmake_build (right):

https://codereview.chromium.org/1916773002/diff/20001/cmake/cmake_build#newco...
cmake/cmake_build:30: pushd $SKIA_OUT/$BUILDTYPE
On 2016/04/25 12:30:50, borenet wrote:
> Note: most bots write to out/$BUILDERNAME/$BUILDTYPE.  Is that necessary here?

When called from the non-swarming bot it was writing to the "wrong" place anyway
so it did not seem to care about the BUILDERNAME.

When called from the swarming bot AFAICT everything writes to out/$BUILDTYPE
(not BUILDERNAME) and is copied out with skia_api.copy_build_products.

[rmistry, 2016-04-25 13:15:16]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2016-04-25 13:15:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1916773002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1916773002/20001

[commit-bot: I haz the power, 2016-04-25 13:29:23]

Description was changed from

==========
Use BUILD_TYPE in cmake_build.

Build files were directly written to the out directory. This change makes them
go to the expected out/{Release, Debug} directory.


BUG=skia:5160

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot
==========

to

==========
Use BUILD_TYPE in cmake_build.

Build files were directly written to the out directory. This change makes them
go to the expected out/{Release, Debug} directory.


BUG=skia:5160

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot

Committed:
https://skia.googlesource.com/skia/+/5d36360c47ed48c93e6928cc5de1a5ebd65b6eea
==========

[commit-bot: I haz the power, 2016-04-25 13:29:24]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5d36360c47ed48c93e6928cc5de1a5ebd65b6eea