Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Issue 1916763003: [turbofan] Move ChangeTaggedToFoo lowerings to EffectControlLinearizer. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move ChangeTaggedToFoo lowerings to EffectControlLinearizer. These also lower to subgraphs that have to be connected to the effect and control chains, otherwise removing the atomic regions around heap allocations would still be unsound. R=jarin@chromium.org Committed: https://crrev.com/dcf178fb294e87958b40953d2ca8f5aa1e8610aa Cr-Commit-Position: refs/heads/master@{#35762}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -390 lines) Patch
M src/compiler/change-lowering.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/change-lowering.cc View 2 chunks +0 lines, -81 lines 0 comments Download
M src/compiler/effect-control-linearizer.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +146 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 chunk +0 lines, -107 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 2 chunks +0 lines, -196 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-25 12:16:25 UTC) #1
Jarin
lgtm
4 years, 8 months ago (2016-04-25 12:18:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916763003/1
4 years, 8 months ago (2016-04-25 12:20:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 12:40:53 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 12:41:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dcf178fb294e87958b40953d2ca8f5aa1e8610aa
Cr-Commit-Position: refs/heads/master@{#35762}

Powered by Google App Engine
This is Rietveld 408576698