Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1916763002: [regexp] Fix non-match and max match length in RegExpCharacterClass. (Closed)

Created:
4 years, 8 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Fix non-match and max match length in RegExpCharacterClass. R=mstarzinger@chromium.org BUG=chromium:605862 LOG=N Committed: https://crrev.com/6f67d171f10040f7096c1d663572c7a1dfe6b036 Cr-Commit-Position: refs/heads/master@{#35764}

Patch Set 1 #

Patch Set 2 : test case #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M src/regexp/jsregexp.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M src/regexp/regexp-ast.h View 1 chunk +4 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-605862.js View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Yang
4 years, 8 months ago (2016-04-25 11:50:12 UTC) #1
Michael Starzinger
LGTM. But I am not familiar with the reg-exp engine at all.
4 years, 8 months ago (2016-04-25 11:53:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916763002/20001
4 years, 8 months ago (2016-04-25 11:54:20 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/4808) v8_linux_dbg_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 8 months ago (2016-04-25 12:24:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916763002/40001
4 years, 8 months ago (2016-04-25 13:08:56 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-25 13:31:01 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 13:32:27 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/6f67d171f10040f7096c1d663572c7a1dfe6b036
Cr-Commit-Position: refs/heads/master@{#35764}

Powered by Google App Engine
This is Rietveld 408576698