chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc - Issue 191673003: Implement ScopedFD in terms of ScopedGeneric.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

Issue 191673003: Implement ScopedFD in terms of ScopedGeneric. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/system/automatic_reboot_manager.cc ('K') | « chrome/browser/chromeos/system/automatic_reboot_manager.cc ('k') | chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc » ('j') | chrome/test/chromedriver/chrome_launcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

diff --git a/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc b/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

index a57fb744449257754a7e54059d39fd508e8dfab9..cf5b80be820fd88ffe5d1bb4f0f0c2a102223b62 100644

--- a/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

+++ b/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

@@ -5,6 +5,7 @@

#include "base/bind.h"

#include "base/file_util.h"

#include "base/files/file_path.h"

+#include "base/files/scoped_file.h"

#include "base/files/scoped_temp_dir.h"

#include "base/json/json_reader.h"

#include "base/memory/scoped_ptr.h"

@@ -214,8 +215,8 @@ TEST_F(NativeMessagingTest, SingleSendMessageWrite) {

#else // defined(OS_WIN)

base::PlatformFile pipe_handles[2];

ASSERT_EQ(0, pipe(pipe_handles));

- file_util::ScopedFD read_fd(pipe_handles);

- file_util::ScopedFD write_fd(pipe_handles + 1);

+ base::ScopedFD read_fd(pipe_handles[0]);

+ base::ScopedFD write_fd(pipe_handles[1]);

read_file = pipe_handles[0];

#endif // !defined(OS_WIN)