Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Side by Side Diff: base/files/scoped_file.cc

Issue 191673003: Implement ScopedFD in terms of ScopedGeneric. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/files/scoped_file.h"
6
7 #include "base/logging.h"
8
9 #if defined(OS_POSIX)
10 #include <unistd.h>
11
12 #include "base/posix/eintr_wrapper.h"
13 #endif
14
15 namespace base {
16 namespace internal {
17
18 #if defined(OS_POSIX)
19
20 // static
21 void ScopedFDCloseTraits::Free(int fd) {
22 // It's important to crash here.
23 // There are security implications to not closing a file descriptor
24 // properly. As file descriptors are "capabilities", keeping them open
25 // would make the current process keep access to a resource. Much of
26 // Chrome relies on being able to "drop" such access.
27 // It's especially problematic on Linux with the setuid sandbox, where
28 // a single open directory would bypass the entire security model.
29 PCHECK(0 == IGNORE_EINTR(close(fd)));
30 }
31
32 #endif // OS_POSIX
33
34 } // namespace internal
35 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698