third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp - Issue 1916703002: Prepare for move-only PassOwnPtr in the remaining directories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 1916703002: Prepare for move-only PassOwnPtr in the remaining directories. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@core1

Patch Set: Merge with trunk. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/threading/BackgroundTaskRunner.cpp ('K') | « third_party/WebKit/Source/web/WebDOMActivityLogger.cpp ('k') | third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp » ('j') | third_party/WebKit/public/platform/WebContentSettingCallbacks.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

index 4883ec22f72c34913262c55de746e386e6e3efe2..91762d335d6e39d06a0a5fe466e7494a5ad04f53 100644

--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

@@ -162,7 +162,7 @@ private:

ClientMessageLoopAdapter(PassOwnPtr<WebDevToolsAgentClient::WebKitClientMessageLoop> messageLoop)

: m_runningForDebugBreak(false)

, m_runningForCreateWindow(false)

- , m_messageLoop(messageLoop) { }

+ , m_messageLoop(std::move(messageLoop)) { }

void run(LocalFrame* frame) override

{

@@ -685,7 +685,7 @@ void WebDevToolsAgentImpl::runDebuggerTask(int sessionId, PassOwnPtr<WebDevTools

void WebDevToolsAgent::interruptAndDispatch(int sessionId, MessageDescriptor* rawDescriptor)

{

// rawDescriptor can't be a PassOwnPtr because interruptAndDispatch is a WebKit API function.

- MainThreadDebugger::interruptMainThreadAndRun(threadSafeBind(WebDevToolsAgentImpl::runDebuggerTask, sessionId, adoptPtr(rawDescriptor)));

+ MainThreadDebugger::interruptMainThreadAndRun(threadSafeBind(WebDevToolsAgentImpl::runDebuggerTask, sessionId, passed(adoptPtr(rawDescriptor))));

}

bool WebDevToolsAgent::shouldInterruptForMessage(const WebString& message)