Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 1916663002: Add null check to WebGLRenderingContextBase::contextGL(). (Closed)

Created:
4 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 8 months ago
Reviewers:
haraken, Zhenyao Mo, bajones
CC:
chromium-reviews, blink-reviews, danakj, sigbjornf
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add null check to WebGLRenderingContextBase::contextGL(). BUG=605988 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/1159e071d7d8b72a210cca6e6a916ef4434b5f00 Cr-Commit-Position: refs/heads/master@{#389391}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
4 years, 8 months ago (2016-04-23 04:42:49 UTC) #3
haraken
LGTM
4 years, 8 months ago (2016-04-23 04:45:04 UTC) #4
Zhenyao Mo
lgtm
4 years, 8 months ago (2016-04-23 05:00:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916663002/1
4 years, 8 months ago (2016-04-23 21:48:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-23 22:53:14 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-23 22:54:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1159e071d7d8b72a210cca6e6a916ef4434b5f00
Cr-Commit-Position: refs/heads/master@{#389391}

Powered by Google App Engine
This is Rietveld 408576698