Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java

Issue 1916583002: Make Chrome on Android progress bar accessible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@load_events
Patch Set: Move to ToolbarProgressBar Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java
index a315012dcd2e88bbfa9bccc59a97b8862a59b12d..3a0c9423e5bcdc02c08ad8b5befd81466c657c59 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java
@@ -8,10 +8,13 @@ import android.animation.TimeAnimator;
import android.animation.TimeAnimator.TimeListener;
import android.content.Context;
import android.graphics.Color;
+import android.support.v4.view.ViewCompat;
import android.text.TextUtils;
import android.util.AttributeSet;
import android.view.ViewGroup;
+import android.view.accessibility.AccessibilityEvent;
import android.widget.FrameLayout.LayoutParams;
+import android.widget.ProgressBar;
import org.chromium.base.CommandLine;
import org.chromium.base.VisibleForTesting;
@@ -132,6 +135,10 @@ public class ToolbarProgressBar extends ClipDrawableProgressBar {
public ToolbarProgressBar(Context context, AttributeSet attrs) {
super(context, attrs);
setAlpha(0.0f);
+
+ // This tells accessibility services that progress bar changes are important enough to
+ // announce to the user even when not focused.
+ ViewCompat.setAccessibilityLiveRegion(this, ViewCompat.ACCESSIBILITY_LIVE_REGION_POLITE);
}
/**
@@ -316,6 +323,7 @@ public class ToolbarProgressBar extends ClipDrawableProgressBar {
} else {
if (!mProgressAnimator.isStarted()) mProgressAnimator.start();
}
+ sendAccessibilityEvent(AccessibilityEvent.TYPE_VIEW_SELECTED);
}
// ClipDrawableProgressBar implementation.
@@ -365,4 +373,16 @@ public class ToolbarProgressBar extends ClipDrawableProgressBar {
ANIMATION_WHITE_FRACTION));
}
}
+
+ @Override
+ public CharSequence getAccessibilityClassName() {
+ return ProgressBar.class.getName();
+ }
+
+ @Override
+ public void onInitializeAccessibilityEvent(AccessibilityEvent event) {
+ super.onInitializeAccessibilityEvent(event);
+ event.setCurrentItemIndex((int) (mTargetProgress * 100));
+ event.setItemCount(100);
+ }
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698