Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 191653002: Shorten duration of audio in audiobuffersource-loop-points WebAudio test (Closed)

Created:
6 years, 9 months ago by Raymond Toy (Google)
Modified:
6 years, 9 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Shorten duration of audio in audiobuffersource-loop-points WebAudio test This test generates 7+ sec of audio, which takes a long time on debug builds. Reduce the length to 1.8 sec by making the notes much shorter and only generating 60 notes (5 octaves) instead of 72. This shouldn't affect the quality of the test. Running local tests for linux, mac, win, and android shows that all of the platform tests are identical and can be removed in favor of just the one reference. BUG=312910, 309197 R=kbr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168942

Patch Set 1 #

Patch Set 2 : Update windows result #

Patch Set 3 : Rebase and update mac result #

Patch Set 4 : Rebase #

Messages

Total messages: 4 (0 generated)
Raymond Toy
PTAL.
6 years, 9 months ago (2014-03-10 22:54:28 UTC) #1
Ken Russell (switch to Gerrit)
lgtm
6 years, 9 months ago (2014-03-10 23:07:37 UTC) #2
Raymond Toy
On 2014/03/10 23:07:37, Ken Russell wrote: > lgtm Thanks!
6 years, 9 months ago (2014-03-10 23:27:37 UTC) #3
Raymond Toy (Google)
6 years, 9 months ago (2014-03-11 19:40:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r168942 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698