Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1916473002: [CacheStorage] Prioritize Size operations over other scheduled operations (Closed)

Created:
4 years, 8 months ago by jkarlin
Modified:
4 years, 8 months ago
Reviewers:
michaeln, jsbell, nhiroki
CC:
chromium-reviews, darin-cc_chromium.org, jam, jkarlin+watch_chromium.org, nhiroki
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CacheStorage] Prioritize Size operations over other scheduled operations This CL runs pending Size() operations immediately after backend initialization instead of in scheduler order. This is because scheduled operations might depend on the QuotaManager which may call Size() mid-operation. BUG=605663 Committed: https://crrev.com/8b14d719f48c5d2b1f2f61fec372ee01e5f938a8 Cr-Commit-Position: refs/heads/master@{#389184}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -11 lines) Patch
M content/browser/cache_storage/cache_storage_cache.h View 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/cache_storage/cache_storage_cache.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M content/browser/cache_storage/cache_storage_cache_unittest.cc View 3 chunks +47 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
jkarlin
michaeln and nhiroki: Hoping to land this one soon as it's a bad bug. I ...
4 years, 8 months ago (2016-04-22 17:54:20 UTC) #3
jsbell
drive-by lgtm
4 years, 8 months ago (2016-04-22 17:56:56 UTC) #5
jkarlin
Thank you jsbell!
4 years, 8 months ago (2016-04-22 18:06:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916473002/1
4 years, 8 months ago (2016-04-22 18:26:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 18:52:15 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:50:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b14d719f48c5d2b1f2f61fec372ee01e5f938a8
Cr-Commit-Position: refs/heads/master@{#389184}

Powered by Google App Engine
This is Rietveld 408576698